Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5799)

Unified Diff: Source/modules/accessibility/AXInlineTextBox.cpp

Issue 1072273006: Oilpan: Prepare moving AXObject to heap (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXInlineTextBox.h ('k') | Source/modules/accessibility/AXLayoutObject.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXInlineTextBox.cpp
diff --git a/Source/modules/accessibility/AXInlineTextBox.cpp b/Source/modules/accessibility/AXInlineTextBox.cpp
index f5dc8573b3b8ae3c462e8774b8c1c667091cb537..79fc5ba8821a67cbdb322daaf77170aceaed15c7 100644
--- a/Source/modules/accessibility/AXInlineTextBox.cpp
+++ b/Source/modules/accessibility/AXInlineTextBox.cpp
@@ -45,15 +45,9 @@ AXInlineTextBox::AXInlineTextBox(PassRefPtr<AbstractInlineTextBox> inlineTextBox
{
}
-AXInlineTextBox::~AXInlineTextBox()
+PassRefPtrWillBeRawPtr<AXInlineTextBox> AXInlineTextBox::create(PassRefPtr<AbstractInlineTextBox> inlineTextBox, AXObjectCacheImpl& axObjectCache)
{
- if (m_axObjectCache && m_inlineTextBox)
- m_axObjectCache->remove(m_inlineTextBox.get());
-}
-
-PassRefPtr<AXInlineTextBox> AXInlineTextBox::create(PassRefPtr<AbstractInlineTextBox> inlineTextBox, AXObjectCacheImpl& axObjectCache)
-{
- return adoptRef(new AXInlineTextBox(inlineTextBox, axObjectCache));
+ return adoptRefWillBeNoop(new AXInlineTextBox(inlineTextBox, axObjectCache));
}
void AXInlineTextBox::init()
@@ -62,9 +56,8 @@ void AXInlineTextBox::init()
void AXInlineTextBox::detach()
{
- m_inlineTextBox = nullptr;
- m_axObjectCache = 0;
AXObject::detach();
+ m_inlineTextBox = nullptr;
}
LayoutRect AXInlineTextBox::elementRect() const
« no previous file with comments | « Source/modules/accessibility/AXInlineTextBox.h ('k') | Source/modules/accessibility/AXLayoutObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698