Chromium Code Reviews| Index: Source/modules/accessibility/AXScrollView.h |
| diff --git a/Source/modules/accessibility/AXScrollView.h b/Source/modules/accessibility/AXScrollView.h |
| index d21e712c8f330b5547d70f9a647321235b92326e..4ad27d65ef45e29bb2f534a5811d0228579beff1 100644 |
| --- a/Source/modules/accessibility/AXScrollView.h |
| +++ b/Source/modules/accessibility/AXScrollView.h |
| @@ -37,11 +37,12 @@ class FrameView; |
| class AXScrollView final : public AXObject { |
| public: |
| - static PassRefPtr<AXScrollView> create(FrameView*, AXObjectCacheImpl*); |
| + static PassRefPtrWillBeRawPtr<AXScrollView> create(FrameView*, AXObjectCacheImpl*); |
| virtual AccessibilityRole roleValue() const override { return ScrollAreaRole; } |
| FrameView* scrollView() const { return m_scrollView; } |
| virtual ~AXScrollView(); |
| + DECLARE_VIRTUAL_TRACE(); |
| virtual void detach() override; |
| protected: |
| @@ -80,14 +81,9 @@ private: |
| // FrameView is disposed. Which clears m_scrollView, hence this |
| // bare pointer will not be stale, so the bare pointer use is safe |
| // & acceptable. |
| - // |
| - // However, it would be preferable to have it be normally traced |
| - // as part of moving the AX objects to the heap. Temporarily using |
| - // a Persistent risks creating a FrameView leak, and brings no |
| - // real benefits overall. |
| - FrameView* m_scrollView; |
| - RefPtr<AXObject> m_horizontalScrollbar; |
| - RefPtr<AXObject> m_verticalScrollbar; |
| + RawPtrWillBeWeakMember<FrameView> m_scrollView; |
|
haraken
2015/06/09 02:25:45
According to the above comment, this raw pointer i
|
| + RefPtrWillBeMember<AXObject> m_horizontalScrollbar; |
| + RefPtrWillBeMember<AXObject> m_verticalScrollbar; |
| bool m_childrenDirty; |
| }; |