Oilpan: Prepare moving AXObject to heap

Source/modules/accessibility/AXObjectCacheImpl.h

Index: Source/modules/accessibility/AXObjectCacheImpl.h
diff --git a/Source/modules/accessibility/AXObjectCacheImpl.h b/Source/modules/accessibility/AXObjectCacheImpl.h
index 4ddc39ae9f07f72bddc1587fc5861bcfbff65d45..46453c1cda3d4d0dc8029617a1eff2407e4df47d 100644
--- a/Source/modules/accessibility/AXObjectCacheImpl.h
+++ b/Source/modules/accessibility/AXObjectCacheImpl.h
@@ -78,6 +78,7 @@ public:
     virtual void remove(LayoutObject*) override;
     virtual void remove(Node*) override;
     virtual void remove(Widget*) override;
+    virtual void remove(AbstractInlineTextBox*) override;
 
     virtual const Element* rootAXEditableElement(const Node*) override;
 
@@ -138,7 +139,6 @@ public:
     AXObject* firstAccessibleObjectFromNode(const Node*);
 
     void remove(AXID);
-    void remove(AbstractInlineTextBox*);
 
     void childrenChanged(AXObject*);
 
@@ -200,18 +200,19 @@ protected:
     void removeNodeForUse(Node* n) { m_textMarkerNodes.remove(n); }
     bool isNodeInUse(Node* n) { return m_textMarkerNodes.contains(n); }
 
-    PassRefPtr<AXObject> createFromRenderer(LayoutObject*);
-    PassRefPtr<AXObject> createFromNode(Node*);
-    PassRefPtr<AXObject> createFromInlineTextBox(AbstractInlineTextBox*);
+    PassRefPtrWillBeRawPtr<AXObject> createFromRenderer(LayoutObject*);
+    PassRefPtrWillBeRawPtr<AXObject> createFromNode(Node*);
+    PassRefPtrWillBeRawPtr<AXObject> createFromInlineTextBox(AbstractInlineTextBox*);
 
 private:
-    Document& m_document;
-    HashMap<AXID, RefPtr<AXObject>> m_objects;
+
+    RawPtrWillBeMember<Document> m_document;
+    WillBeHeapHashMap<AXID, RefPtrWillBeMember<AXObject>> m_objects;
     HashMap<LayoutObject*, AXID> m_layoutObjectMapping;
-    HashMap<Widget*, AXID> m_widgetObjectMapping;
-    HashMap<Node*, AXID> m_nodeObjectMapping;
+    WillBeHeapHashMap<RawPtrWillBeMember<Widget>, AXID> m_widgetObjectMapping;
+    WillBeHeapHashMap<RawPtrWillBeMember<Node>, AXID> m_nodeObjectMapping;
     HashMap<AbstractInlineTextBox*, AXID> m_inlineTextBoxObjectMapping;

[dmazzoni, 2015/06/08 15:25:49]

Why not a HeapHashMap for this?

Would it make sense to have a comment explaining why some of these are
HeapHashMaps and others are not?

[haraken, 2015/06/09 02:25:45]

Worth having a comment. The reason is that LayoutObject and
AbstractInlineTextBox are not (yet) in Oilpan's heap. So we cannot use a
HeapHashMap.

[keishi, 2015/06/09 05:51:19]

Added comment.

-    HashSet<Node*> m_textMarkerNodes;
+    WillBeHeapHashSet<RawPtrWillBeWeakMember<Node>> m_textMarkerNodes;
     int m_modificationCount;
 
     HashSet<AXID> m_idsInUse;
@@ -249,7 +250,7 @@ private:
     HashMap<String, OwnPtr<HashSet<AXID>>> m_idToAriaOwnersMapping;
 
     Timer<AXObjectCacheImpl> m_notificationPostTimer;
-    Vector<pair<RefPtr<AXObject>, AXNotification>> m_notificationsToPost;
+    WillBeHeapVector<pair<RefPtrWillBeMember<AXObject>, AXNotification>> m_notificationsToPost;
     void notificationPostTimerFired(Timer<AXObjectCacheImpl>*);
 
     AXObject* focusedImageMapUIElement(HTMLAreaElement*);