Chromium Code Reviews| Index: Source/modules/accessibility/AXScrollView.h |
| diff --git a/Source/modules/accessibility/AXScrollView.h b/Source/modules/accessibility/AXScrollView.h |
| index d21e712c8f330b5547d70f9a647321235b92326e..350c6b2fa89ae4169980c8f057dcf6d95aa46dd5 100644 |
| --- a/Source/modules/accessibility/AXScrollView.h |
| +++ b/Source/modules/accessibility/AXScrollView.h |
| @@ -37,11 +37,12 @@ class FrameView; |
| class AXScrollView final : public AXObject { |
| public: |
| - static PassRefPtr<AXScrollView> create(FrameView*, AXObjectCacheImpl*); |
| + static PassRefPtrWillBeRawPtr<AXScrollView> create(FrameView*, AXObjectCacheImpl*); |
| virtual AccessibilityRole roleValue() const override { return ScrollAreaRole; } |
| FrameView* scrollView() const { return m_scrollView; } |
| virtual ~AXScrollView(); |
| + DECLARE_VIRTUAL_TRACE(); |
| virtual void detach() override; |
| protected: |
| @@ -85,9 +86,9 @@ private: |
| // as part of moving the AX objects to the heap. Temporarily using |
| // a Persistent risks creating a FrameView leak, and brings no |
| // real benefits overall. |
| - FrameView* m_scrollView; |
| - RefPtr<AXObject> m_horizontalScrollbar; |
| - RefPtr<AXObject> m_verticalScrollbar; |
| + RawPtrWillBeWeakMember<FrameView> m_scrollView; |
|
haraken
2015/05/28 10:48:42
Would you elaborate on why this needs to be weak?
|
| + RefPtrWillBeMember<AXObject> m_horizontalScrollbar; |
| + RefPtrWillBeMember<AXObject> m_verticalScrollbar; |
| bool m_childrenDirty; |
| }; |