Oilpan: Prepare moving AXObject to heap

Source/modules/accessibility/AXSpinButton.cpp

 /*
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
@@ skipping 13 matching lines @@
  */
 
 #include "config.h"
 #include "modules/accessibility/AXSpinButton.h"
 
 #include "core/layout/LayoutObject.h"
 #include "modules/accessibility/AXObjectCacheImpl.h"
 
 namespace blink {
 
-PassRefPtr<AXSpinButton> AXSpinButton::create(AXObjectCacheImpl* axObjectCache)
+PassRefPtrWillBeRawPtr<AXSpinButton> AXSpinButton::create(AXObjectCacheImpl* axObjectCache)
 {
-    return adoptRef(new AXSpinButton(axObjectCache));
+    return adoptRefWillBeNoop(new AXSpinButton(axObjectCache));
 }
 
 AXSpinButton::AXSpinButton(AXObjectCacheImpl* axObjectCache)
     : AXMockObject(axObjectCache)
-    , m_spinButtonElement(0)
+    , m_spinButtonElement(nullptr)
 {
 }
 
 AXSpinButton::~AXSpinButton()
 {
 }
 
+DEFINE_TRACE(AXSpinButton)
+{
+    AXMockObject::trace(visitor);
+    visitor->trace(m_spinButtonElement);
+}
+
 LayoutRect AXSpinButton::elementRect() const
 {
     if (!m_spinButtonElement || !m_spinButtonElement->layoutObject())
         return LayoutRect();
 
     return LayoutRect(m_spinButtonElement->layoutObject()->absoluteFocusRingBoundingBoxRect());
 }
 
 void AXSpinButton::detach()
 {
     AXObject::detach();
-    m_spinButtonElement = 0;
+    m_spinButtonElement = nullptr;
 }
 
 void AXSpinButton::detachFromParent()

[haraken, 2015/05/28 10:48:42]

Some AXObjects have detachFromParent() but some AXObjects don't. What's the
difference? I guess all AXObjects that have raw pointers (on non-oilpan builds)
need to implement detachFromParent() and clear the raw pointers.

 {
     AXObject::detachFromParent();
-    m_spinButtonElement = 0;
+    m_spinButtonElement = nullptr;
 }
 
 AccessibilityRole AXSpinButton::roleValue() const
 {
     return m_spinButtonElement ? SpinButtonRole : UnknownRole;
 }
 
 void AXSpinButton::addChildren()
 {
     m_haveChildren = true;
@@ skipping 19 matching lines @@
 }
 
 // AXSpinButtonPart
 
 AXSpinButtonPart::AXSpinButtonPart(AXObjectCacheImpl* axObjectCache)
     : AXMockObject(axObjectCache)
     , m_isIncrementor(false)
 {
 }
 
-PassRefPtr<AXSpinButtonPart> AXSpinButtonPart::create(AXObjectCacheImpl* axObjectCache)
+PassRefPtrWillBeRawPtr<AXSpinButtonPart> AXSpinButtonPart::create(AXObjectCacheImpl* axObjectCache)
 {
-    return adoptRef(new AXSpinButtonPart(axObjectCache));
+    return adoptRefWillBeNoop(new AXSpinButtonPart(axObjectCache));
 }
 
 LayoutRect AXSpinButtonPart::elementRect() const
 {
     // FIXME: This logic should exist in the layout tree or elsewhere, but there is no
     // relationship that exists that can be queried.
 
     LayoutRect parentRect = parentObject()->elementRect();
     if (m_isIncrementor) {
         parentRect.setHeight(parentRect.height() / 2);
@@ skipping 13 matching lines @@
     AXSpinButton* spinButton = toAXSpinButton(parentObject());
     if (m_isIncrementor)
         spinButton->step(1);
     else
         spinButton->step(-1);
 
     return true;
 }
 
 } // namespace blink