Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: tools/clang/plugins/FindBadConstructsConsumer.cpp

Issue 1072203002: Build the Clang plugin on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Win path checking and comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/clang/plugins/FindBadConstructsConsumer.cpp
diff --git a/tools/clang/plugins/FindBadConstructsConsumer.cpp b/tools/clang/plugins/FindBadConstructsConsumer.cpp
index 770e2551d6e7c92f12032f850251ba5b8af738d1..b9a0ef8ea59f96b120a0f7c7d52067751565d696 100644
--- a/tools/clang/plugins/FindBadConstructsConsumer.cpp
+++ b/tools/clang/plugins/FindBadConstructsConsumer.cpp
@@ -559,8 +559,14 @@ FindBadConstructsConsumer::CheckRecordForRefcountIssue(
// Adds either a warning or error, based on the current handling of
// -Werror.
DiagnosticsEngine::Level FindBadConstructsConsumer::getErrorLevel() {
+#ifdef LLVM_ON_WIN32
+ // Only warn on Windows, since there are a lot of potential pre-existing
+ // issues.
+ return DiagnosticsEngine::Warning;
+#else
return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error
: DiagnosticsEngine::Warning;
+#endif
}
// Returns true if |base| specifies one of the Chromium reference counted

Powered by Google App Engine
This is Rietveld 408576698