OLD | NEW |
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "FindBadConstructsConsumer.h" | 5 #include "FindBadConstructsConsumer.h" |
6 | 6 |
7 #include "clang/Frontend/CompilerInstance.h" | 7 #include "clang/Frontend/CompilerInstance.h" |
8 #include "clang/AST/Attr.h" | 8 #include "clang/AST/Attr.h" |
9 #include "clang/Lex/Lexer.h" | 9 #include "clang/Lex/Lexer.h" |
10 #include "llvm/Support/raw_ostream.h" | 10 #include "llvm/Support/raw_ostream.h" |
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
552 return PublicDestructor; | 552 return PublicDestructor; |
553 } | 553 } |
554 } | 554 } |
555 | 555 |
556 return None; | 556 return None; |
557 } | 557 } |
558 | 558 |
559 // Adds either a warning or error, based on the current handling of | 559 // Adds either a warning or error, based on the current handling of |
560 // -Werror. | 560 // -Werror. |
561 DiagnosticsEngine::Level FindBadConstructsConsumer::getErrorLevel() { | 561 DiagnosticsEngine::Level FindBadConstructsConsumer::getErrorLevel() { |
| 562 #if defined(LLVM_ON_WIN32) |
| 563 // Only warn on Windows, since there are a lot of potential pre-existing |
| 564 // issues. |
| 565 return DiagnosticsEngine::Warning; |
| 566 #else |
562 return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error | 567 return diagnostic().getWarningsAsErrors() ? DiagnosticsEngine::Error |
563 : DiagnosticsEngine::Warning; | 568 : DiagnosticsEngine::Warning; |
| 569 #endif |
564 } | 570 } |
565 | 571 |
566 // Returns true if |base| specifies one of the Chromium reference counted | 572 // Returns true if |base| specifies one of the Chromium reference counted |
567 // classes (base::RefCounted / base::RefCountedThreadSafe). | 573 // classes (base::RefCounted / base::RefCountedThreadSafe). |
568 bool FindBadConstructsConsumer::IsRefCountedCallback( | 574 bool FindBadConstructsConsumer::IsRefCountedCallback( |
569 const CXXBaseSpecifier* base, | 575 const CXXBaseSpecifier* base, |
570 CXXBasePath& path, | 576 CXXBasePath& path, |
571 void* user_data) { | 577 void* user_data) { |
572 FindBadConstructsConsumer* self = | 578 FindBadConstructsConsumer* self = |
573 static_cast<FindBadConstructsConsumer*>(user_data); | 579 static_cast<FindBadConstructsConsumer*>(user_data); |
(...skipping 213 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
787 // one of those, it means there is at least one member after a factory. | 793 // one of those, it means there is at least one member after a factory. |
788 if (weak_ptr_factory_location.isValid() && | 794 if (weak_ptr_factory_location.isValid() && |
789 !param_is_weak_ptr_factory_to_self) { | 795 !param_is_weak_ptr_factory_to_self) { |
790 diagnostic().Report(weak_ptr_factory_location, | 796 diagnostic().Report(weak_ptr_factory_location, |
791 diag_weak_ptr_factory_order_); | 797 diag_weak_ptr_factory_order_); |
792 } | 798 } |
793 } | 799 } |
794 } | 800 } |
795 | 801 |
796 } // namespace chrome_checker | 802 } // namespace chrome_checker |
OLD | NEW |