Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1072193012: Revert of [Mac] AppControllerMac updates the window when a Profile is deleted. (Closed)

Created:
5 years, 8 months ago by horo
Modified:
5 years, 8 months ago
CC:
chromium-reviews, rginda+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Mac] AppControllerMac updates the window when a Profile is deleted. (patchset #6 id:120001 of https://codereview.chromium.org/1097553002/) Reason for revert: browser_tests failure http://build.chromium.org/p/chromium.mac/builders/Mac10.8%20Tests/builds/1394/steps/browser_tests/logs/AppControllerMainMenuBrowserTest.HistoryMenuResetAfterProfileDeletion Original issue's description: > AppControllerMac updates the window when a Profile is deleted. > > BUG=477392 > TEST=(Mac only) Have at least two profiles. Open one of the profiles. navigate to generate browser history, verify it in the History Menu. Delete the profile; note that history should no longer show the deleted profile's history. > > Committed: https://crrev.com/ef6d33eabfb3d553153217a3b874dd6a0cfdf961 > Cr-Commit-Position: refs/heads/master@{#326281} TBR=rsesek@chromium.org,mlerman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477392 Committed: https://crrev.com/94111201ae249b1741f79e581d1d45080db7202b Cr-Commit-Position: refs/heads/master@{#326422}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -79 lines) Patch
M chrome/browser/app_controller_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/app_controller_mac.mm View 2 chunks +2 lines, -11 lines 0 comments Download
M chrome/browser/app_controller_mac_browsertest.mm View 3 chunks +0 lines, -66 lines 0 comments Download
M chrome/browser/profiles/profile_manager.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
horo
Created Revert of [Mac] AppControllerMac updates the window when a Profile is deleted.
5 years, 8 months ago (2015-04-23 01:46:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072193012/1
5 years, 8 months ago (2015-04-23 01:49:50 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 01:53:02 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 01:54:00 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/94111201ae249b1741f79e581d1d45080db7202b
Cr-Commit-Position: refs/heads/master@{#326422}

Powered by Google App Engine
This is Rietveld 408576698