Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1072193009: Fix for GrAtlasTextContext memory leak (Closed)

Created:
5 years, 8 months ago by joshua.litt
Modified:
5 years, 8 months ago
Reviewers:
joshualitt, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix for GrAtlasTextContext memory leak BUG=skia: Committed: https://skia.googlesource.com/skia/+/12c20e40a47a454049cda8240a9b3d8918ac06ef

Patch Set 1 #

Total comments: 1

Patch Set 2 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
joshualitt
ptal
5 years, 8 months ago (2015-04-22 18:00:47 UTC) #2
joshualitt
ptal
5 years, 8 months ago (2015-04-22 18:01:35 UTC) #3
bsalomon
https://codereview.chromium.org/1072193009/diff/1/src/gpu/GrAtlasTextContext.h File src/gpu/GrAtlasTextContext.h (right): https://codereview.chromium.org/1072193009/diff/1/src/gpu/GrAtlasTextContext.h#newcode255 src/gpu/GrAtlasTextContext.h:255: ~BitmapTextBlob() { override, otherwise lgtm
5 years, 8 months ago (2015-04-22 18:16:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072193009/20001
5 years, 8 months ago (2015-04-22 18:18:44 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 18:24:27 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/12c20e40a47a454049cda8240a9b3d8918ac06ef

Powered by Google App Engine
This is Rietveld 408576698