Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1072193005: Revert of Revert of [es6] implement Array.prototype.copyWithin() (Closed)

Created:
5 years, 8 months ago by Michael Achenbach
Modified:
5 years, 8 months ago
CC:
v8-dev
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of [es6] implement Array.prototype.copyWithin() (patchset #1 id:1 of https://codereview.chromium.org/1084183004/) Reason for revert: Check if this CL fails independently of https://chromium.googlesource.com/v8/v8/+/580d66bcda66220d2f3062ac58daf925436df74c Original issue's description: > Revert of [es6] implement Array.prototype.copyWithin() (patchset #7 id:120001 of https://codereview.chromium.org/376623004/) > > Reason for revert: > [Sheriff] This causes test failures on mac gc stress: > http://build.chromium.org/p/client.v8/builders/V8%20Mac%20GC%20Stress/builds/1027 > > Original issue's description: > > [es6] implement Array.prototype.copyWithin() > > > > https://people.mozilla.org/~jorendorff/es6-draft.html#sec-array.prototype.copywithin > > > > BUG=v8:4039 > > R=adamk@chromium.org > > LOG=N > > TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4039 > > Committed: https://crrev.com/9283fc89710e59445bdc4479454fba97ab9ebdd7 > Cr-Commit-Position: refs/heads/master@{#27984} TBR=dslomov@chromium.org,rossberg@chromium.org,adamk@chromium.org,caitpotter88@gmail.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4039 Committed: https://crrev.com/27397421f8ce54a494c169a2625c511687fa5a0c Cr-Commit-Position: refs/heads/master@{#27997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+393 lines, -0 lines) Patch
M src/harmony-array.js View 3 chunks +55 lines, -0 lines 0 comments Download
A test/mjsunit/harmony/array-copywithin.js View 1 chunk +338 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Revert of [es6] implement Array.prototype.copyWithin()
5 years, 8 months ago (2015-04-22 09:43:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072193005/1
5 years, 8 months ago (2015-04-22 09:43:24 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-22 09:43:36 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-22 13:19:18 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/27397421f8ce54a494c169a2625c511687fa5a0c
Cr-Commit-Position: refs/heads/master@{#27997}

Powered by Google App Engine
This is Rietveld 408576698