Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: ui/views/controls/menu/menu_event_dispatcher.cc

Issue 1072193004: Take GetCharacterFromKeyCode() out behind the barn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/test/event_generator.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_event_dispatcher.cc
diff --git a/ui/views/controls/menu/menu_event_dispatcher.cc b/ui/views/controls/menu/menu_event_dispatcher.cc
index db49f90b0b27ed9897926dbb149101ce3b733ff8..2211c02039d32e69d8ff36f96fc3d480138c9d24 100644
--- a/ui/views/controls/menu/menu_event_dispatcher.cc
+++ b/ui/views/controls/menu/menu_event_dispatcher.cc
@@ -58,7 +58,7 @@ uint32_t MenuEventDispatcher::DispatchEvent(const ui::PlatformEvent& event) {
// Do not check mnemonics if the Alt or Ctrl modifiers are pressed.
int flags = key_event->flags();
if ((flags & (ui::EF_CONTROL_DOWN | ui::EF_ALT_DOWN)) == 0) {
- char c = ui::GetCharacterFromKeyCode(key_event->key_code(), flags);
+ char c = ui::DomCodeToUsLayoutCharacter(key_event->code(), flags);
menu_controller_->SelectByChar(c);
}
break;
« no previous file with comments | « ui/events/test/event_generator.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698