tests/SwizzlerTest.cpp - Issue 1072183002: Fix ASAN error

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/SwizzlerTest.cpp

Issue 1072183002: Fix ASAN error (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/SwizzlerTest.cpp

diff --git a/tests/SwizzlerTest.cpp b/tests/SwizzlerTest.cpp

index 1355f3be8ca1045bb9ce18fb62474e93cbb5d71b..f02f86b68260e864d2ec5af617c4ca08390f160d 100644

--- a/tests/SwizzlerTest.cpp

+++ b/tests/SwizzlerTest.cpp

@@ -28,7 +28,7 @@ static void check_fill(skiatest::Reporter* r,

const size_t totalBytes = imageInfo.getSafeSize(rowBytes) + offset;

// Create fake image data where every byte has a value of 0

- SkAutoTDelete<uint8_t> storage((uint8_t*) sk_malloc_throw(totalBytes));

+ SkAutoTDeleteArray<uint8_t> storage(SkNEW_ARRAY(uint8_t, totalBytes));

memset(storage.get(), 0, totalBytes);

// Adjust the pointer in order to test on different memory alignments

uint8_t* imageData = storage.get() + offset;

« no previous file with comments | « no previous file | no next file » | no next file with comments »