Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3348)

Unified Diff: chrome/browser/ui/omnibox/omnibox_popup_model.h

Issue 1072163003: Make GetInfoForCurrentText() return the correct match when we've selected an (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comments Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | components/omnibox/autocomplete_match.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/omnibox/omnibox_popup_model.h
diff --git a/chrome/browser/ui/omnibox/omnibox_popup_model.h b/chrome/browser/ui/omnibox/omnibox_popup_model.h
index dc5f7344b10d879a83984626fef93f62563ba52a..c87302b52c760d0aae80428a954b462dd31ad0d3 100644
--- a/chrome/browser/ui/omnibox/omnibox_popup_model.h
+++ b/chrome/browser/ui/omnibox/omnibox_popup_model.h
@@ -87,8 +87,14 @@ class OmniboxPopupModel {
void Move(int count);
// If the selected line has both a normal match and a keyword match, this can
Mark P 2015/04/21 21:54:08 FYI: I would love if this is said associated_keywo
Peter Kasting 2015/04/21 21:58:00 I think that's a slight layering violation, commen
- // be used to choose which to select. It is an error to call this when the
- // selected line does not have both matches (or there is no selection).
+ // be used to choose which to select. This allows the user to toggle between
+ // normal and keyword mode with tab/shift-tab without rerunning autocomplete
+ // or disturbing other popup state, which in turn is an important part of
+ // supporting the use of tab to do both tab-to-search and
+ // tab-to-traverse-dropdown.
+ //
+ // It is an error to call this when the selected line does not have both
+ // matches (or there is no selection).
void SetSelectedLineState(LineState state);
// Called when the user hits shift-delete. This should determine if the item
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | components/omnibox/autocomplete_match.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698