Add granular file tracing.

base/files/file.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/file.h"
 #include "base/files/file_path.h"
 #include "base/metrics/histogram.h"
 #include "base/timer/elapsed_timer.h"
+#include "base/trace_event/trace_event.h"
 
 #if defined(OS_POSIX)
 #include "base/files/file_posix_hooks_internal.h"
 #endif
 
 namespace base {
 
 File::Info::Info()
     : size(0),
       is_directory(false),
       is_symbolic_link(false) {
 }
 
 File::Info::~Info() {
 }
 
 File::File()
     : error_details_(FILE_ERROR_FAILED),
       created_(false),
       async_(false) {
 }
 
 #if !defined(OS_NACL)
-File::File(const FilePath& name, uint32 flags)
+File::File(const FilePath& path, uint32 flags)
     : error_details_(FILE_OK),
       created_(false),
       async_(false) {
-  Initialize(name, flags);
+  Initialize(path, flags);
 }
 #endif
 
 File::File(PlatformFile platform_file)
     : file_(platform_file),
       error_details_(FILE_OK),
       created_(false),
       async_(false) {
 #if defined(OS_POSIX)
   DCHECK_GE(platform_file, -1);
   if (IsValid())
     ProtectFileDescriptor(platform_file);
 #endif
 }
 
 File::File(Error error_details)
     : error_details_(error_details),
       created_(false),
       async_(false) {
 }
 
 File::File(RValue other)
     : file_(other.object->TakePlatformFile()),
+      path_(other.object->path_),
       error_details_(other.object->error_details()),
       created_(other.object->created()),
       async_(other.object->async_) {
 #if defined(OS_POSIX)
-   if (IsValid())
-     ProtectFileDescriptor(GetPlatformFile());
+  if (IsValid())
+    ProtectFileDescriptor(GetPlatformFile());
 #endif
 }
 
 File::~File() {
   // Go through the AssertIOAllowed logic.
   Close();
+  TRACE_EVENT_ASYNC_END1(kTraceGroup, "File", this,

[Lei Zhang, 2015/04/27 22:55:55]

We may not always call TRACE_EVENT_ASYNC_BEGIN1() in Initialize(), would that
mismatch cause trouble here?

[Dan Beam, 2015/04/28 03:17:11]

not sure but just made this TRACE_EVENT_ASYNC_{BEGIN/END}0 instead and just
passing |this| (omitting path_)

+                         "path", path_.AsUTF8Unsafe());

[Dan Beam, 2015/04/24 22:27:02]

should I be passing along the path here?

 }
 
 File& File::operator=(RValue other) {
   if (this != other.object) {
     Close();
     SetPlatformFile(other.object->TakePlatformFile());
     error_details_ = other.object->error_details();
     created_ = other.object->created();

[Lei Zhang, 2015/04/27 22:55:55]

Set |path_| here too?

[Dan Beam, 2015/04/28 03:17:11]

Done.

     async_ = other.object->async_;
   }
   return *this;
 }
 
 #if !defined(OS_NACL)
-void File::Initialize(const FilePath& name, uint32 flags) {
-  if (name.ReferencesParent()) {
+void File::Initialize(const FilePath& path, uint32 flags) {
+  path_ = path;
+  if (path_.ReferencesParent()) {
     error_details_ = FILE_ERROR_ACCESS_DENIED;
     return;
   }
-  DoInitialize(name, flags);
+  TRACE_EVENT_ASYNC_BEGIN1(kTraceGroup, "File", this,
+                           "path", path_.AsUTF8Unsafe());
+  DoInitialize(flags);
 }
 #endif
 
 std::string File::ErrorToString(Error error) {
   switch (error) {
     case FILE_OK:
       return "FILE_OK";
     case FILE_ERROR_FAILED:
       return "FILE_ERROR_FAILED";
     case FILE_ERROR_IN_USE:
@@ skipping 27 matching lines @@
     case FILE_ERROR_IO:
       return "FILE_ERROR_IO";
     case FILE_ERROR_MAX:
       break;
   }
 
   NOTREACHED();
   return "";
 }
 
+// static
+const char File::kTraceGroup[] = TRACE_DISABLED_BY_DEFAULT("file");
+
 bool File::Flush() {
   ElapsedTimer timer;
   bool return_value = DoFlush();
   UMA_HISTOGRAM_TIMES("PlatformFile.FlushTime", timer.Elapsed());
   return return_value;
 }
 
 }  // namespace base