src/messages.js - Issue 1072083002: [es6] don't "replace" Object.prototype.toString for --harmony-tostring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/messages.js

Issue 1072083002: [es6] don't "replace" Object.prototype.toString for --harmony-tostring (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Final fixup... Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/messages.js

diff --git a/src/messages.js b/src/messages.js

index 72637fb76e6abadbb214a41e07c3349c26b8ec6c..c55515536131101f86299d323bad662fa6cc6bfd 100644

--- a/src/messages.js

+++ b/src/messages.js

@@ -248,7 +248,7 @@ function NoSideEffectToString(obj) {

}

if (IS_SYMBOL(obj)) return %_CallFunction(obj, $symbolToString);

if (IS_OBJECT(obj)

- && %GetDataProperty(obj, "toString") === DefaultObjectToString) {

+ && %GetDataProperty(obj, "toString") === ObjectToString) {

var constructor = %GetDataProperty(obj, "constructor");

if (typeof constructor == "function") {

var constructorName = constructor.name;

« no previous file with comments | « src/heap/heap.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »