[es6] don't "replace" Object.prototype.toString for --harmony-tostring

[es6] don't "replace" Object.prototype.toString for --harmony-tostring

When ObjectToString is installed on Object.prototype twice (once in v8natives.js, and once in harmony-tostring.js), this pollutes old code spaces on some devices. To prevent this, the function is only installed once, preventing test failures when the --harmony-tostring flag is flipped on by default.

BUG=v8:3502
LOG=N
R=arv@chromium.org

Committed: https://crrev.com/48eff34c323aa430cb3605079f9322e0310149d0
Cr-Commit-Position: refs/heads/master@{#27720}

[caitp (gmail), 2015-04-09 15:54:38]

PTAL

It's crrev.com/1072573002 without the flag flip, so that it's easier to revert
the flag flip if needed

[arv (Not doing code reviews), 2015-04-09 16:44:48]

LGTM

The CL description could be expanded a bit to explain the motivation better.

[caitp (gmail), 2015-04-09 16:52:40]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-04-09 16:53:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072083002/20001

[commit-bot: I haz the power, 2015-04-09 17:16:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-09 17:16:12]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4694)

[caitp (gmail), 2015-04-09 17:18:48]

On 2015/04/09 17:16:12, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_linux64_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4694)

oh come on @_@

[caitp (gmail), 2015-04-09 18:14:41]

On 2015/04/09 17:16:12, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_linux64_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4694)

I don't really understand the try failures, since I can't reproduce them locally
at all (including an xcode build like the mac_rel bot). :|

[arv (Not doing code reviews), 2015-04-09 18:16:09]

On 2015/04/09 18:14:41, caitp wrote:
> On 2015/04/09 17:16:12, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   v8_linux64_rel on tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4694)
> 
> I don't really understand the try failures, since I can't reproduce them
locally
> at all (including an xcode build like the mac_rel bot). :|

The bootstrapping is always hard to get to work. Maybe you can look at how
harmony regexp works?

[arv (Not doing code reviews), 2015-04-09 18:16:09]

On 2015/04/09 18:14:41, caitp wrote:
> On 2015/04/09 17:16:12, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   v8_linux64_rel on tryserver.v8 (JOB_FAILED,
> >
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4694)
> 
> I don't really understand the try failures, since I can't reproduce them
locally
> at all (including an xcode build like the mac_rel bot). :|

The bootstrapping is always hard to get to work. Maybe you can look at how
harmony regexp works?

[caitp (gmail), 2015-04-09 18:47:22]

On 2015/04/09 18:16:09, arv wrote:
> On 2015/04/09 18:14:41, caitp wrote:
> > On 2015/04/09 17:16:12, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders:
> > >   v8_linux64_rel on tryserver.v8 (JOB_FAILED,
> > >
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4694)
> > 
> > I don't really understand the try failures, since I can't reproduce them
> locally
> > at all (including an xcode build like the mac_rel bot). :|
> 
> The bootstrapping is always hard to get to work. Maybe you can look at how
> harmony regexp works?

Tried something similar, tests pass locally... I dunno, try it? it's getting so
much messier than it should be :|

[arv (Not doing code reviews), 2015-04-09 19:27:17]

LGTM

Lets hope this works.

[caitp (gmail), 2015-04-09 19:28:11]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2015-04-09 19:28:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072083002/80001

[caitp (gmail), 2015-04-09 19:47:03]

On 2015/04/09 19:28:39, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1072083002/80001

hmm.. the win_rel failure looks like a non-fluke, but again, not able to repro
locally

[commit-bot: I haz the power, 2015-04-09 19:49:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-09 19:49:45]

Try jobs failed on following builders:
  v8_linux64_rel on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4697)

[caitp (gmail), 2015-04-09 19:56:45]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-04-09 19:56:46]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1072083002/#ps100001
(title: "Final fixup...")

[commit-bot: I haz the power, 2015-04-09 19:57:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1072083002/100001

[caitp (gmail), 2015-04-09 19:57:36]

On 2015/04/09 19:49:45, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   v8_linux64_rel on tryserver.v8 (JOB_FAILED,
> http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel/builds/4697)

I guess I couldn't repro due to not running the webkit tests. fixed that one.
(I'm not sure why we're calling this "NoSideEffectsToString" in messages.js,
there certainly can be side effects there I think)

[commit-bot: I haz the power, 2015-04-09 20:53:51]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-04-09 20:54:05]

Patchset 6 (id:??) landed as
https://crrev.com/48eff34c323aa430cb3605079f9322e0310149d0
Cr-Commit-Position: refs/heads/master@{#27720}