Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1180)

Issue 1072063002: Remove ARM assembly memsets. (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove ARM assembly memsets. Step 1 of a zillion in the quest for NEON on iOS, and step 1 of a different zillion in the Great Assembly Purge. ios, arm, arm64, arm_v7, arm_v7_neon all build. BUG=skia: Committed: https://skia.googlesource.com/skia/+/a67572ff91cc88ac8a9bb3d7f3d7c636c5ee02e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -144 lines) Patch
M gyp/opts.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/opts.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/opts/SkUtils_opts_arm.cpp View 1 chunk +8 lines, -29 lines 0 comments Download
D src/opts/memset.arm.S View 1 chunk +0 lines, -113 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtklein_C
5 years, 8 months ago (2015-04-09 15:45:26 UTC) #2
djsollen
lgtm
5 years, 8 months ago (2015-04-09 15:51:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072063002/1
5 years, 8 months ago (2015-04-09 15:51:42 UTC) #5
reed1
lgtm
5 years, 8 months ago (2015-04-09 16:03:09 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 16:16:32 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/a67572ff91cc88ac8a9bb3d7f3d7c636c5ee02e1

Powered by Google App Engine
This is Rietveld 408576698