Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 1072053002: Revert of Re-subimission of https://codereview.chromium.org/1041213003/ (Closed)

Created:
5 years, 8 months ago by nednguyen
Modified:
5 years, 8 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-subimission of https://codereview.chromium.org/1041213003/ (patchset #2 id:20001 of https://codereview.chromium.org/1056533003/) Reason for revert: Speculative revert (https://code.google.com/p/chromium/issues/detail?id=474977) BUG=474977 Original issue's description: > Re-subimission of https://codereview.chromium.org/1041213003/ > > 1. Use window.performance.timing instead of statsCollectionController to get page loading time. > 2. Fix waiting condition to avoid racing condition > > BUG=472603, 467964 > > Committed: https://crrev.com/ad8d3f3d9182bb82f89c5d29e0c455d8deb8c15a > Cr-Commit-Position: refs/heads/master@{#324118} TBR=dtu@chromium.org,aiolos@chromium.org,cylee@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=472603, 467964 Committed: https://crrev.com/ac561df1bc7f47f11af6a2569293bdd4942c09b5 Cr-Commit-Position: refs/heads/master@{#324447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M tools/perf/metrics/startup_metric.py View 3 chunks +34 lines, -34 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
nednguyen
Created Revert of Re-subimission of https://codereview.chromium.org/1041213003/
5 years, 8 months ago (2015-04-09 15:31:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072053002/1
5 years, 8 months ago (2015-04-09 15:31:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 15:32:33 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ac561df1bc7f47f11af6a2569293bdd4942c09b5 Cr-Commit-Position: refs/heads/master@{#324447}
5 years, 8 months ago (2015-04-09 15:33:27 UTC) #4
nednguyen
5 years, 8 months ago (2015-04-09 18:06:29 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1073873002/ by nednguyen@google.com.

The reason for reverting is: THe original patch actually fixes the problem..

Powered by Google App Engine
This is Rietveld 408576698