Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1198)

Issue 1072033002: Avoid sending empty bitmaps through proxy canvas (Closed)

Created:
5 years, 8 months ago by tomhudson
Modified:
5 years, 8 months ago
Reviewers:
djsollen, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid sending empty bitmaps through proxy canvas Some back ends may crash when asked to draw an empty bitmap, so we filter it out here. BUG=skia:3692 R=djsollen@google.com,reed@google.com Committed: https://skia.googlesource.com/skia/+/2df6fd650cb12af8eeb7884b2819d2bf8ba7a5bf

Patch Set 1 #

Patch Set 2 : After discussion moved to SkCanvas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M src/core/SkCanvas.cpp View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tomhudson
PTAL
5 years, 8 months ago (2015-04-09 15:06:39 UTC) #1
djsollen
what backends fail? I don't think there is anything preventing java apps from attempting to ...
5 years, 8 months ago (2015-04-09 15:13:07 UTC) #2
tomhudson
This is the crash I was seeing last night when I started trying to diagnosing ...
5 years, 8 months ago (2015-04-09 15:16:39 UTC) #3
tomhudson
Moved checks to SkCanvas pre-virtuals.
5 years, 8 months ago (2015-04-09 15:31:02 UTC) #5
djsollen
lgtm pending mike's ok.
5 years, 8 months ago (2015-04-09 15:43:39 UTC) #6
reed1
lgtm
5 years, 8 months ago (2015-04-09 16:01:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072033002/20001
5 years, 8 months ago (2015-04-09 16:01:52 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 16:20:22 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2df6fd650cb12af8eeb7884b2819d2bf8ba7a5bf

Powered by Google App Engine
This is Rietveld 408576698