Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1072003002: Early return the Clipboard Url Provider when the omnibox wasn't focused. (Closed)

Created:
5 years, 8 months ago by jif
Modified:
5 years, 8 months ago
Reviewers:
sdefresne
CC:
chromium-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Early return the Clipboard Url Provider when the omnibox wasn't focused. This mirrors what other similar providers do: https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/autocomplete/zero_suggest_provider.cc&rcl=1428507553&l=98 BUG=None. Committed: https://crrev.com/aee072743f8339a3520e74ed08818f5a981561a3 Cr-Commit-Position: refs/heads/master@{#324427}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M components/open_from_clipboard/clipboard_url_provider.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jif
ptal
5 years, 8 months ago (2015-04-09 12:57:08 UTC) #2
sdefresne
lgtm
5 years, 8 months ago (2015-04-09 13:19:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1072003002/1
5 years, 8 months ago (2015-04-09 13:20:06 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-09 13:42:51 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:43:47 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aee072743f8339a3520e74ed08818f5a981561a3
Cr-Commit-Position: refs/heads/master@{#324427}

Powered by Google App Engine
This is Rietveld 408576698