Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Unified Diff: Source/core/loader/FrameLoader.cpp

Issue 1071893003: WebURLRequest: Track the requesting document's URL through navigations. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/loader/FrameLoader.cpp
diff --git a/Source/core/loader/FrameLoader.cpp b/Source/core/loader/FrameLoader.cpp
index 0a0e3d26685a203ee94ca18329a24631a68cd5f1..20f2bc0425ae9fb033c02d1bbcd6f7e6368b0188 100644
--- a/Source/core/loader/FrameLoader.cpp
+++ b/Source/core/loader/FrameLoader.cpp
@@ -786,10 +786,12 @@ void FrameLoader::load(const FrameLoadRequest& passedRequest)
FrameLoadType newLoadType = determineFrameLoadType(request);
NavigationPolicy policy = navigationPolicyForRequest(request);
if (shouldOpenInNewWindow(targetFrame.get(), request, policy)) {
- if (policy == NavigationPolicyDownload)
+ if (policy == NavigationPolicyDownload) {
client()->loadURLExternally(request.resourceRequest(), NavigationPolicyDownload);
- else
+ } else {
+ request.resourceRequest().setFrameType(WebURLRequest::FrameTypeAuxiliary);
jochen (gone - plz use gerrit) 2015/04/13 13:07:02 should this be in a different CL?
Mike West 2015/04/21 12:46:22 As long as you don't mind reviewing two CreateWind
createWindowForRequest(request, *m_frame, policy, request.shouldSendReferrer());
+ }
return;
}

Powered by Google App Engine
This is Rietveld 408576698