Source/modules/accessibility/AXNodeObject.h - Issue 1071873004: Changing slider values do not work properly when percent change of a step is less than one.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.h

Issue 1071873004: Changing slider values do not work properly when percent change of a step is less than one. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Just did some cleanup Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/accessibility/input-type-range-value-change-expected.txt ('k') | Source/modules/accessibility/AXNodeObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/accessibility/AXNodeObject.h

diff --git a/Source/modules/accessibility/AXNodeObject.h b/Source/modules/accessibility/AXNodeObject.h

index 5a1dd645ff111108a3320b90f537e48a15ed8c9c..d71f3719cdaeba6d5842d784f9b853b3489f9222 100644

--- a/Source/modules/accessibility/AXNodeObject.h

+++ b/Source/modules/accessibility/AXNodeObject.h

@@ -65,7 +65,6 @@ protected:

String ariaAccessibilityDescription() const;

String ariaAutoComplete() const;

void ariaLabeledByElements(WillBeHeapVector<RawPtrWillBeMember<Element>>& elements) const;

- void changeValueByStep(bool increase);

AccessibilityRole determineAriaRoleAttribute() const;

void elementsFromAttribute(WillBeHeapVector<RawPtrWillBeMember<Element>>& elements, const QualifiedName&) const;

bool hasContentEditableAttributeSet() const;

@@ -113,6 +112,7 @@ protected:

virtual bool isPasswordField() const override final;

virtual bool isProgressIndicator() const override;

virtual bool isSlider() const override;

+ virtual bool isNativeSlider() const override;

// Check object state.

virtual bool isChecked() const override final;

@@ -201,7 +201,6 @@ private:

String alternativeTextForWebArea() const;

void alternativeText(Vector<AccessibilityText>&) const;

void ariaLabeledByText(Vector<AccessibilityText>&) const;

- void changeValueByPercent(float percentChange);

float stepValueForRange() const;

AXObject* findChildWithTagName(const HTMLQualifiedName&) const;

};