Prefer ComposedTreeTraversal to NodeRenderingTraversal.

Prefer ComposedTreeTraversal to NodeRenderingTraversal.

This CL is one of a series of patches for BUG 472973.

The replacement is almost done, except for a few cases where NodeRenderingTraversal should be used.
I'll take a deeper look at remaining cases in a follow-up patch.

BUG=472973
TEST=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193425

[hayato, 2015-04-09 04:42:38]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2015-04-09 04:42:39]

PTAL

[kochi, 2015-04-09 05:01:47]

lgtm (with a comment)

https://codereview.chromium.org/1071863002/diff/1/Source/core/dom/Node.cpp
File Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1071863002/diff/1/Source/core/dom/Node.cpp#ne...
Source/core/dom/Node.cpp:797: if (dialog && this != document() &&
canParticipateInComposedTree() && !ComposedTreeTraversal::contains(*dialog,
*this))
(Just a comment)
This looks somewhat tricky as other parts are mechanical replacement, while
this CTT::contains() you have to take care that the target element should meet
canParticipateInComposedTree() condition.
It should be okay because that condition is caugut in CTT::contains() as
assertPrecondition().

[tkent, 2015-04-09 05:29:33]

lgtm

[hayato, 2015-04-09 05:34:40]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2015-04-09 05:34:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071863002/1

[hayato, 2015-04-09 05:35:01]

https://codereview.chromium.org/1071863002/diff/1/Source/core/dom/Node.cpp
File Source/core/dom/Node.cpp (right):

https://codereview.chromium.org/1071863002/diff/1/Source/core/dom/Node.cpp#ne...
Source/core/dom/Node.cpp:797: if (dialog && this != document() &&
canParticipateInComposedTree() && !ComposedTreeTraversal::contains(*dialog,
*this))
On 2015/04/09 05:01:47, Takayoshi Kochi wrote:
> (Just a comment)
> This looks somewhat tricky as other parts are mechanical replacement, while
> this CTT::contains() you have to take care that the target element should meet
> canParticipateInComposedTree() condition.
> It should be okay because that condition is caugut in CTT::contains() as
> assertPrecondition().

Acknowledged. 
canParticipateInComposedTree() is necessary here to avoid hitting assertion
because Node::isInert might be called for (active) insertion points.

[commit-bot: I haz the power, 2015-04-09 07:49:07]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193425

[dsinclair, 2015-04-09 19:50:52]

On 2015/04/09 at 07:49:07, commit-bot wrote:
> Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193425

This seems to have broken hit testing on ::backdrop elements. Can you please
take a look at crbug.com/475565.