Issue 1071843003: Fix bug in AndroidDeviceManager::DeviceProvider::HttpUpgrade()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1071843003: Fix bug in AndroidDeviceManager::DeviceProvider::HttpUpgrade() (Closed)

Created:
5 years, 8 months ago by horo

Modified:
5 years, 8 months ago

Reviewers:

CC:
chromium-reviews, aandrey+blink_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix bug in AndroidDeviceManager::DeviceProvider::HttpUpgrade() In the current implementation, HttpRequest in android_device_manager.cc can't handle the leading data frames of WebSocket. This cl fixes this bug by sending the leading bytes to AndroidDeviceManager::AndroidWebSocket::Connected(). BUG=475352

Patch Set 1 #

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+46 lines, -26 lines)			Patch
M	chrome/browser/devtools/device/android_device_manager.h	View	2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/devtools/device/android_device_manager.cc	View	4 chunks	+18 lines, -12 lines	0 comments	Download
M	chrome/browser/devtools/device/android_web_socket.cc	View	6 chunks	+23 lines, -12 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

horo

5 years, 8 months ago (2015-04-09 13:13:37 UTC) #1

tyoshino@ has created better cl.
https://codereview.chromium.org/1078733002/

So I will close this cl.

Expand Messages | Collapse Messages