Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Issue 1071833002: Remove SK_SUPPORT_LEGACY_SCALAR_MAPPOINTS (Closed)

Created:
5 years, 8 months ago by f(malita)
Modified:
5 years, 8 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SK_SUPPORT_LEGACY_SCALAR_MAPPOINTS No longer used in Chromium. Also drop now-unused SkMatrix::Rot_pts() & SkMatrix::RotTrans_pts(). BUG=475022 R=reed@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/f57546ec7f9ab116d80044e19aa5e72060dbff09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M include/core/SkMatrix.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/core/SkMatrix.cpp View 2 chunks +0 lines, -52 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
f(malita)
5 years, 8 months ago (2015-04-09 02:19:10 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071833002/1
5 years, 8 months ago (2015-04-09 02:20:07 UTC) #3
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-04-09 02:25:41 UTC) #5
mtklein
lgtm
5 years, 8 months ago (2015-04-09 10:12:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071833002/1
5 years, 8 months ago (2015-04-09 12:51:21 UTC) #8
commit-bot: I haz the power
Presubmit check for 1071833002-1 failed and returned exit status 1. Running presubmit commit checks ...
5 years, 8 months ago (2015-04-09 12:51:26 UTC) #10
reed1
lgtm
5 years, 8 months ago (2015-04-09 13:06:20 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071833002/1
5 years, 8 months ago (2015-04-09 13:13:08 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-09 13:13:19 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f57546ec7f9ab116d80044e19aa5e72060dbff09

Powered by Google App Engine
This is Rietveld 408576698