Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1071813002: Implement chrome.sockets.udp.setBroadcast. (Closed)

Created:
5 years, 8 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 8 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, asvitkine+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement chrome.sockets.udp.setBroadcast. Enable Chrome Apps to receive broadcast UDP traffic by setting the SO_BROADCAST option on a socket. This feature piggybacks on existing permissions as it requires a socket to be bound to the interface where the broadcast traffic will be received. BUG=308461 Committed: https://crrev.com/92c5e06599547fa733d45f4c000a31acbe0c66f8 Cr-Commit-Position: refs/heads/master@{#324768}

Patch Set 1 : #

Patch Set 2 : Rebased. #

Patch Set 3 : Rebased again. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -1 line) Patch
M extensions/browser/api/socket/udp_socket.h View 1 chunk +2 lines, -0 lines 0 comments Download
M extensions/browser/api/socket/udp_socket.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.h View 1 chunk +18 lines, -0 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M extensions/browser/extension_function_histogram_value.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/api/sockets_udp.idl View 2 chunks +13 lines, -0 lines 0 comments Download
M extensions/test/data/sockets_udp/api/background.js View 2 chunks +90 lines, -1 line 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Reilly Grant (use Gerrit)
Please take a look.
5 years, 8 months ago (2015-04-10 19:38:08 UTC) #3
rpaquay
lgtm
5 years, 8 months ago (2015-04-10 19:44:06 UTC) #4
Reilly Grant (use Gerrit)
Adding asvitkine@ for the histograms update.
5 years, 8 months ago (2015-04-10 19:50:21 UTC) #6
Alexei Svitkine (slow)
lgtm, but you probably have to rebase as someone beat you to 999 and there's ...
5 years, 8 months ago (2015-04-10 20:36:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071813002/40001
5 years, 8 months ago (2015-04-10 22:30:20 UTC) #10
commit-bot: I haz the power
Failed to apply patch for extensions/browser/extension_function_histogram_value.h: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-11 00:28:32 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071813002/60001
5 years, 8 months ago (2015-04-11 00:45:19 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 8 months ago (2015-04-11 03:47:42 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-04-11 03:48:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/92c5e06599547fa733d45f4c000a31acbe0c66f8
Cr-Commit-Position: refs/heads/master@{#324768}

Powered by Google App Engine
This is Rietveld 408576698