Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1071783003: Add root certificate bundle to curl package, and improve git default setup. (Closed)

Created:
5 years, 8 months ago by bradn
Modified:
5 years, 8 months ago
Reviewers:
Sam Clegg
CC:
native-client-reviews_googlegroups.com, Sam Clegg
Base URL:
https://chromium.googlesource.com/external/naclports.git@master
Target Ref:
refs/heads/master
Project:
naclports
Visibility:
Public.

Description

Add root certificate bundle to curl package, and improve git default setup. Adding root certs to the curl package. Changing devenv to use these certs by default. Note we may want to evaluate if the curl scripting around root certs is sufficient. It downloads from mozilla. Adding a default .gitconfig that supresses warnings due to lack of /etc/passwd and git templates. This change should make git clone and push from https urls work out of the box. BUG=None TEST=local manual R=sbc@chromium.org Committed: https://chromium.googlesource.com/external/naclports/+/3369ff26a53f5fe7852efc7052cd284d505736b9

Patch Set 1 #

Total comments: 6

Patch Set 2 : fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M ports/curl/build.sh View 1 chunk +1 line, -0 lines 0 comments Download
M ports/devenv/bashrc View 1 1 chunk +13 lines, -0 lines 1 comment Download
M ports/devenv/setup-environment View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
bradn
5 years, 8 months ago (2015-04-08 23:27:28 UTC) #1
Sam Clegg
this is very cool! lgtm https://codereview.chromium.org/1071783003/diff/1/ports/curl/build.sh File ports/curl/build.sh (right): https://codereview.chromium.org/1071783003/diff/1/ports/curl/build.sh#newcode70 ports/curl/build.sh:70: ${SRC_DIR}/lib/mk-ca-bundle.pl So we require ...
5 years, 8 months ago (2015-04-08 23:35:00 UTC) #2
Sam Clegg
First line of CL could be more informative. How about "Add root certificate bundle to ...
5 years, 8 months ago (2015-04-08 23:36:28 UTC) #3
bradn
Committed patchset #2 (id:20001) manually as 3369ff26a53f5fe7852efc7052cd284d505736b9 (presubmit successful).
5 years, 8 months ago (2015-04-09 00:01:11 UTC) #4
bradn
https://codereview.chromium.org/1071783003/diff/1/ports/curl/build.sh File ports/curl/build.sh (right): https://codereview.chromium.org/1071783003/diff/1/ports/curl/build.sh#newcode70 ports/curl/build.sh:70: ${SRC_DIR}/lib/mk-ca-bundle.pl On 2015/04/08 23:34:59, Sam Clegg wrote: > So ...
5 years, 8 months ago (2015-04-09 00:07:21 UTC) #5
Sam Clegg
5 years, 8 months ago (2015-04-10 21:02:11 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1071783003/diff/20001/ports/devenv/bashrc
File ports/devenv/bashrc (right):

https://codereview.chromium.org/1071783003/diff/20001/ports/devenv/bashrc#new...
ports/devenv/bashrc:19: # Setiing up a default git identity, since we lack
/etc/passwd as
Setting

Powered by Google App Engine
This is Rietveld 408576698