metalet with postfix improvement

lib/runtime/dart/_isolate_helper.js

 var _isolate_helper;
 (function(exports) {
   'use strict';
   // Function _serializeMessage: (dynamic) → dynamic
   function _serializeMessage(message) {
     return new _Serializer().serialize(message);
   }
   // Function _deserializeMessage: (dynamic) → dynamic
   function _deserializeMessage(message) {
     return new _Deserializer().deserialize(message);
@@ skipping 340 matching lines @@
   }
   // Function _callInIsolate: (_IsolateContext, Function) → dynamic
   function _callInIsolate(isolate, function$0) {
     let result = isolate.eval(function$0);
     exports._globalState.topEventLoop.run();
     return result;
   }
   let _activeJsAsyncCount = Symbol('_activeJsAsyncCount');
   // Function enterJsAsync: () → dynamic
   function enterJsAsync() {
-    let o$ = exports._globalState.topEventLoop;
-    o$[_activeJsAsyncCount] = dart.notNull(o$[_activeJsAsyncCount]) + 1;
+    dart.prop(exports._globalState.topEventLoop, _activeJsAsyncCount).notNull++;

[vsm, 2015/04/09 16:58:28]

How about just specializing the increment case?  E.g.,

dart.dincrement(exports._globalState.topEventLoop, _activeJsAsyncCount)

with optional args for increment (1 by default) and perhaps pre/post (post by
default):

dart.dincrement(exports._globalState.topEventLoop, _activeJsAsyncCount, -1)

?

[Jennifer Messerly, 2015/04/09 17:47:40]

yeah, that could work, would we have different prefix vs postfix variants, or
only postifx?

Note the diff in this CL is a bit misleading, I only added support for postfix
so far, so prefix/op assign won't show up.

[vsm, 2015/04/10 00:14:10]

Another alternative:

dart.nullcheck(exports._globalState.topEventLoop, _activeJsAsyncCount)++;

i.e., fold the notNull and prop into one since it's such a common pattern.

In general, the fact that x.notNull++ changes x is surprising to me.

[Jennifer Messerly, 2015/04/10 01:00:24]

that won't work though ... it has to be an lvalue. The ".notNull" is so we get
an lvalue.

it could be: `dart.nullcheck(obj, prop).value` ... that was just more wordy,
only reason I didn't go for it.
yeah, it's all degrees of terrible, IMHO =\

   }
   // Function leaveJsAsync: () → dynamic
   function leaveJsAsync() {
-    let o$ = exports._globalState.topEventLoop;
-    o$[_activeJsAsyncCount] = dart.notNull(o$[_activeJsAsyncCount]) - 1;
+    dart.prop(exports._globalState.topEventLoop, _activeJsAsyncCount).notNull--;
     dart.assert(dart.notNull(exports._globalState.topEventLoop[_activeJsAsyncCount]) >= 0);
   }
   // Function isWorker: () → bool
   function isWorker() {
     return exports._globalState.isWorker;
   }
   // Function _currentIsolate: () → _IsolateContext
   function _currentIsolate() {
     return exports._globalState.currentContext;
   }
@@ skipping 98 matching lines @@
   }
   let _controlPort = Symbol('_controlPort');
   let _scheduledControlEvents = Symbol('_scheduledControlEvents');
   let _isExecutingEvent = Symbol('_isExecutingEvent');
   let _updateGlobalState = Symbol('_updateGlobalState');
   let _setGlobals = Symbol('_setGlobals');
   let _addRegistration = Symbol('_addRegistration');
   let _close = Symbol('_close');
   class _IsolateContext extends core.Object {
     _IsolateContext() {
-      this.id = (() => {
-        let o$ = exports._globalState, x$ = o$.nextIsolateId;
-        o$.nextIsolateId = dart.notNull(x$) + 1;
-        return x$;
-      })();
+      this.id = dart.prop(exports._globalState, 'nextIsolateId').notNull++;
       this.ports = new (core.Map$(core.int, RawReceivePortImpl))();
       this.weakPorts = new (core.Set$(core.int))();
       this.isolateStatics = _foreign_helper.JS_CREATE_ISOLATE();
       this.controlPort = new RawReceivePortImpl[_controlPort]();
       this.pauseCapability = new isolate.Capability();
       this.terminateCapability = new isolate.Capability();
       this.delayedEvents = dart.as(new core.List.from([]), core.List$(_IsolateEvent));
       this.pauseTokens = dart.as(new core.Set(), core.Set$(isolate.Capability));
       this.errorPorts = dart.as(new core.Set(), core.Set$(isolate.SendPort));
       this.initialized = false;
@@ skipping 590 matching lines @@
         };
       }(_foreign_helper.DART_CLOSURE_TO_JS(IsolateNatives.workerOnError), uri, onError);
       worker.onerror = onerrorTrampoline;
       let processWorkerMessageTrampoline = function(f, a) {
         return function(e) {
           e.onerror = null;
           return f(a, e);
         };
       }(_foreign_helper.DART_CLOSURE_TO_JS(IsolateNatives[_processWorkerMessage]), worker);
       worker.onmessage = processWorkerMessageTrampoline;
-      let o$ = exports._globalState;
-      let workerId = o$.nextManagerId;
-      o$.nextManagerId = dart.notNull(workerId) + 1;
+      let workerId = dart.prop(exports._globalState, 'nextManagerId').notNull++;
       IsolateNatives.workerIds.set(worker, workerId);
       exports._globalState.managers.set(workerId, worker);
       worker.postMessage(_serializeMessage(dart.map({command: 'start', id: workerId, replyTo: _serializeMessage(replyPort), args: args, msg: _serializeMessage(message), isSpawnUri: isSpawnUri, startPaused: startPaused, functionName: functionName})));
     }
     static workerOnError(event, uri, onError) {
       event.preventDefault();
       let message = dart.as(event.message, core.String);
       if (message == null) {
         message = `Error spawning worker for ${uri}`;
       } else {
@@ skipping 278 matching lines @@
   exports.leaveJsAsync = leaveJsAsync;
   exports.isWorker = isWorker;
   exports.startRootIsolate = startRootIsolate;
   exports.IsolateNatives = IsolateNatives;
   exports.RawReceivePortImpl = RawReceivePortImpl;
   exports.ReceivePortImpl = ReceivePortImpl;
   exports.TimerImpl = TimerImpl;
   exports.hasTimer = hasTimer;
   exports.CapabilityImpl = CapabilityImpl;
 })(_isolate_helper || (_isolate_helper = {}));