gn-mode: Get fill-paragraph working correctly.

gn-mode: Get fill-paragraph working correctly.

Define a fill-paragraph-function which only fills in comments instead of
everywhere. Previously, we would fill in other contexts, like lists.

BUG=none

Committed: https://crrev.com/1251868f89c1f22d159b332c96f1eec4a079abbc
Cr-Commit-Position: refs/heads/master@{#324328}

[Elliot Glaysher, 2015-04-08 19:37:54]

erg@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2015-04-08 22:19:31]

"Bad content. Try to upload again."

[Nico, 2015-04-08 22:19:43]

nvm, "raw" works. reviewing there

[Nico, 2015-04-08 22:26:31]

lgtm

I read
http://www.gnu.org/software/emacs/manual/html_node/elisp/Interactive-Codes.ht...
and http://www.gnu.org/software/emacs/manual/html_node/elisp/Filling.html , this
might be correct – but I don't really know what I'm reviewing :-)

Instead of

  (or (somefun foo)  t)

could you write

  (somefun foo)
  t

? (if so, up to you if you think that's clearer)

[Elliot Glaysher, 2015-04-08 22:31:45]

On 2015/04/08 22:26:31, Nico wrote:
> lgtm
> 
> I read
>
http://www.gnu.org/software/emacs/manual/html_node/elisp/Interactive-Codes.ht...
> and http://www.gnu.org/software/emacs/manual/html_node/elisp/Filling.html ,
this
> might be correct – but I don't really know what I'm reviewing :-)

I apologize; I don't really know of anyone else who can do these reviews and am
only sending them to you because you've done elisp reviews before. If you know
of a better reviewer, I'd love to hear it.

> Instead of
> 
>   (or (somefun foo)  t)
> 
> could you write
> 
>   (somefun foo)
>   t
> 
> ? (if so, up to you if you think that's clearer)

I'm uncertain of which is cleaner, but I'm going to do the first because of
consistency with at least the core fill.el code in emacs, which uses (or ...)
this way.

[Elliot Glaysher, 2015-04-08 22:31:50]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2015-04-08 22:34:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071733002/40001

[Nico, 2015-04-08 22:38:42]

On Wed, Apr 8, 2015 at 3:31 PM, <erg@chromium.org> wrote:

> On 2015/04/08 22:26:31, Nico wrote:
>
>> lgtm
>>
>
>  I read
>>
>
> http://www.gnu.org/software/emacs/manual/html_node/elisp/
> Interactive-Codes.html#Interactive-Codes
>
>> and http://www.gnu.org/software/emacs/manual/html_node/elisp/Filling.html
>> ,
>>
> this
>
>> might be correct – but I don't really know what I'm reviewing :-)
>>
>
> I apologize; I don't really know of anyone else who can do these reviews
> and am
> only sending them to you because you've done elisp reviews before. If you
> know
> of a better reviewer, I'd love to hear it.


Modelstly, I can't think of anyone who would be more qualified than _me_. I
asked on my internal g+ though, maybe someone more qualified will appear
soon. If so, I'll let you know :-)


>
>
>  Instead of
>>
>
>     (or (somefun foo)  t)
>>
>
>  could you write
>>
>
>     (somefun foo)
>>    t
>>
>
>  ? (if so, up to you if you think that's clearer)
>>
>
> I'm uncertain of which is cleaner, but I'm going to do the first because of
> consistency with at least the core fill.el code in emacs, which uses (or
> ...)
> this way.
>
> https://codereview.chromium.org/1071733002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-04-09 01:08:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-04-09 01:10:48]

Patchset 3 (id:??) landed as
https://crrev.com/1251868f89c1f22d159b332c96f1eec4a079abbc
Cr-Commit-Position: refs/heads/master@{#324328}