Issue 107173002: Use non C++11 version of SafeSNPrintf() when building with gcc

Issue 107173002: Use non C++11 version of SafeSNPrintf() when building with gcc (Closed)

Created:
7 years ago by Inactive

Modified:
7 years ago

Reviewers:
Nico

CC:
chromium-reviews, erikwright+watch_chromium.org, jshin+watch_chromium.org, Markus (顧孟勤)

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Use non C++11 version of SafeSNPrintf() when building with gcc Use non C++11 version of SafeSNPrintf() when building with gcc. Even though gcc >= 4.3 support variadic templates when C++11 support is enabled, the C++11 version of SafeSNPrintf() still does not build with gcc (tested with gcc 4.7). R=Nico BUG=233330

Patch Set 1 #

Total comments: 3

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	base/strings/safe_sprintf.h	View		1 chunk	+3 lines, -1 line	3 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Inactive

I see the following build error with g++ 4.7 otherwise: ../../base/strings/safe_sprintf.h: In function ‘ssize_t base::strings::SafeSNPrintf(char*, ...

7 years ago (2013-12-05 21:05:09 UTC) #1

I see the following build error with g++ 4.7 otherwise:

../../base/strings/safe_sprintf.h: In function ‘ssize_t
base::strings::SafeSNPrintf(char*, size_t, const char*, Args ...)’:
../../base/strings/safe_sprintf.h:200:90: error: no matching function for call
to ‘ArraySizeHelper(const base::strings::internal::Arg [])’
../../base/strings/safe_sprintf.h:200:90: note: candidates are:
In file included from ../../base/strings/safe_sprintf.h:20:0,
                 from ../../base/strings/safe_sprintf.cc:5:
../../base/basictypes.h:128:8: note: template<class T, long unsigned int N> char
(& ArraySizeHelper(T (&)[N]))[N]
../../base/basictypes.h:128:8: note:   template argument deduction/substitution
failed:
In file included from ../../base/strings/safe_sprintf.cc:5:0:
../../base/strings/safe_sprintf.h:200:90: note:   mismatched types ‘T [N]’ and
‘const base::strings::internal::Arg []’
In file included from ../../base/strings/safe_sprintf.h:20:0,
                 from ../../base/strings/safe_sprintf.cc:5:
../../base/basictypes.h:135:8: note: template<class T, long unsigned int N> char
(& ArraySizeHelper(const T (&)[N]))[N]
../../base/basictypes.h:135:8: note:   template argument deduction/substitution
failed:
In file included from ../../base/strings/safe_sprintf.cc:5:0:
../../base/strings/safe_sprintf.h:200:90: note:   mismatched types ‘const T [N]’
and ‘const base::strings::internal::Arg []’
../../base/strings/safe_sprintf.h: In function ‘ssize_t
base::strings::SafeSPrintf(char (&)[N], const char*, Args ...)’:
../../base/strings/safe_sprintf.h:208:90: error: no matching function for call
to ‘ArraySizeHelper(const base::strings::internal::Arg [])’
../../base/strings/safe_sprintf.h:208:90: note: candidates are:
In file included from ../../base/strings/safe_sprintf.h:20:0,
                 from ../../base/strings/safe_sprintf.cc:5:
../../base/basictypes.h:128:8: note: template<class T, long unsigned int N> char
(& ArraySizeHelper(T (&)[N]))[N]
../../base/basictypes.h:128:8: note:   template argument deduction/substitution
failed:
In file included from ../../base/strings/safe_sprintf.cc:5:0:
../../base/strings/safe_sprintf.h:208:90: note:   mismatched types ‘T [N]’ and
‘const base::strings::internal::Arg []’
In file included from ../../base/strings/safe_sprintf.h:20:0,
                 from ../../base/strings/safe_sprintf.cc:5:
../../base/basictypes.h:135:8: note: template<class T, long unsigned int N> char
(& ArraySizeHelper(const T (&)[N]))[N]
../../base/basictypes.h:135:8: note:   template argument deduction/substitution
failed:
In file included from ../../base/strings/safe_sprintf.cc:5:0:
../../base/strings/safe_sprintf.h:208:90: note:   mismatched types ‘const T [N]’
and ‘const base::strings::internal::Arg []’
[1544/10178] CXX obj/base/strings/base.string_util.o

Nico

https://codereview.chromium.org/107173002/diff/1/base/strings/safe_sprintf.h File base/strings/safe_sprintf.h (left): https://codereview.chromium.org/107173002/diff/1/base/strings/safe_sprintf.h#oldcode193 base/strings/safe_sprintf.h:193: #if __cplusplus >= 201103 // C++11 Huh where did ...

7 years ago (2013-12-05 21:11:35 UTC) #2

Inactive

7 years ago (2013-12-05 21:15:14 UTC) #3

Nico

On 2013/12/05 21:15:14, Chris Dumez wrote: > https://codereview.chromium.org/107173002/diff/1/base/strings/safe_sprintf.h > File base/strings/safe_sprintf.h (left): > > https://codereview.chromium.org/107173002/diff/1/base/strings/safe_sprintf.h#oldcode193 ...

7 years ago (2013-12-05 21:16:55 UTC) #5

Inactive

7 years ago (2013-12-05 21:27:19 UTC) #6

On 2013/12/05 21:16:55, Nico wrote:
> On 2013/12/05 21:15:14, Chris Dumez wrote:
> > https://codereview.chromium.org/107173002/diff/1/base/strings/safe_sprintf.h
> > File base/strings/safe_sprintf.h (left):
> > 
> >
>
https://codereview.chromium.org/107173002/diff/1/base/strings/safe_sprintf.h#...
> > base/strings/safe_sprintf.h:193: #if __cplusplus >= 201103  // C++11
> > On 2013/12/05 21:11:35, Nico wrote:
> > > Huh where did that come from? We should probably delete this block.
> > 
> > Hmm. This is a bit more readable than the non-C++11 alternative. I think the
> > idea was to switch everyone to that code once all compilers support it.
> 
> Right, but it looks like this probably won't happen for another year (see
"c++11
> status" or "c+=11 update" thread (forgot the exact title) on chromium-dev). I
> commented on https://chromiumcodereview.appspot.com/23777003/ about removing
the
> c++11 bits.
> 
> I was able to build with gcc4.7 in c++11 mode a while ago, but it'll keep
> breaking until we have bot coverage, and we won't have bot coverage until we
> decide we can ship something building in that configuration (again, see that
> thread).

Dropping this in favor of https://codereview.chromium.org/102993006/ then.

Expand Messages | Collapse Messages