Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(222)

Unified Diff: runtime/vm/object.h

Issue 1071713003: - Remove JSCRE from the runtime. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.h
===================================================================
--- runtime/vm/object.h (revision 44981)
+++ runtime/vm/object.h (working copy)
@@ -7496,25 +7496,12 @@
virtual bool CanonicalizeEquals(const Instance& other) const;
- static const intptr_t kBytesPerElement = 1;
- static const intptr_t kMaxElements = kSmiMax / kBytesPerElement;
-
static intptr_t InstanceSize() {
- ASSERT(sizeof(RawJSRegExp) == OFFSET_OF_RETURNED_VALUE(RawJSRegExp, data));
- if (FLAG_use_jscre) {
- return 0;
- }
return RoundedAllocationSize(sizeof(RawJSRegExp));
}
- static intptr_t InstanceSize(intptr_t len) {
- ASSERT(0 <= len && len <= kMaxElements);
- return RoundedAllocationSize(
- sizeof(RawJSRegExp) + (len * kBytesPerElement));
- }
+ static RawJSRegExp* New(Heap::Space space = Heap::kNew);
- static RawJSRegExp* New(intptr_t length, Heap::Space space = Heap::kNew);
-
private:
void set_type(RegExType type) const {
StoreNonPointer(&raw_ptr()->type_flags_,
@@ -7532,12 +7519,6 @@
return FlagsBits::decode(raw_ptr()->type_flags_);
}
- void SetLength(intptr_t value) const {
- // This is only safe because we create a new Smi, which does not cause
- // heap allocation.
- StoreSmi(&raw_ptr()->data_length_, Smi::New(value));
- }
-
FINAL_HEAP_OBJECT_IMPLEMENTATION(JSRegExp, Instance);
friend class Class;
};

Powered by Google App Engine
This is Rietveld 408576698