Remove #include <asm/unistd.h> from linux_syscall_ranges.h and syscall.cc.

Remove #include <asm/unistd.h> from linux_syscall_ranges.h and syscall.cc.

The header is included for __NR_SYSCALL_BASE and __ARM_NR_BASE.
Some toolchain (in particular, PNaCl toolchain) does not provide
asm/unistd.h (so that neither __NR_SYSCALL_BASE nor __ARM_NR_BASE
is provided).
This CL removes the dependency to asm/unistd.h from linux_syscall_ranges.h,
instead define the values if necessary.

Also, this CL removes the include from syscall.cc, too, which is
unused.

TEST=Ran bots.
BUG=358465
Committed: https://crrev.com/c2352bce792e735fc6be6f2d62c03652a3111e16
Cr-Commit-Position: refs/heads/master@{#324371}

[hidehiko, 2015-04-08 17:26:09]

hidehiko@chromium.org changed reviewers:
+ mdempsky@chromium.org

[hidehiko, 2015-04-08 17:26:10]

PTAL.

[mdempsky, 2015-04-08 18:23:51]

lgtm

https://codereview.chromium.org/1071653002/diff/1/sandbox/linux/bpf_dsl/linux...
File sandbox/linux/bpf_dsl/linux_syscall_ranges.h (right):

https://codereview.chromium.org/1071653002/diff/1/sandbox/linux/bpf_dsl/linux...
sandbox/linux/bpf_dsl/linux_syscall_ranges.h:28: #define __NR_SYSCALL_BASE 0
Unless you think there's any particular value to still providing these #defines
broken out separately, I'd probably just inline them below and simplify like for
x86-64 and x86 above.

https://codereview.chromium.org/1071653002/diff/1/sandbox/linux/bpf_dsl/linux...
sandbox/linux/bpf_dsl/linux_syscall_ranges.h:44: #define MIN_SYSCALL        
__NR_O32_Linux
I think this will require <asm/unistd.h>?  Unfortunately, there aren't any MIPS
bots. :-/

Maybe for now just move the #include <asm/unistd.h> into this #elif block.

[hidehiko, 2015-04-09 01:02:11]

Patchset #2 (id:20001) has been deleted

[hidehiko, 2015-04-09 02:34:37]

Thank you for review. Submitting.

https://codereview.chromium.org/1071653002/diff/1/sandbox/linux/bpf_dsl/linux...
File sandbox/linux/bpf_dsl/linux_syscall_ranges.h (right):

https://codereview.chromium.org/1071653002/diff/1/sandbox/linux/bpf_dsl/linux...
sandbox/linux/bpf_dsl/linux_syscall_ranges.h:28: #define __NR_SYSCALL_BASE 0
On 2015/04/08 18:23:51, mdempsky wrote:
> Unless you think there's any particular value to still providing these
#defines
> broken out separately, I'd probably just inline them below and simplify like
for
> x86-64 and x86 above.

Done.

https://codereview.chromium.org/1071653002/diff/1/sandbox/linux/bpf_dsl/linux...
sandbox/linux/bpf_dsl/linux_syscall_ranges.h:44: #define MIN_SYSCALL        
__NR_O32_Linux
On 2015/04/08 18:23:51, mdempsky wrote:
> I think this will require <asm/unistd.h>?  Unfortunately, there aren't any
MIPS
> bots. :-/
> 
> Maybe for now just move the #include <asm/unistd.h> into this #elif block.

Good catch. Fixed.

[hidehiko, 2015-04-09 02:34:41]

The CQ bit was checked by hidehiko@chromium.org

[hidehiko, 2015-04-09 02:34:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
mdempsky@chromium.org
Link to the patchset: https://codereview.chromium.org/1071653002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-04-09 02:35:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071653002/40001

[commit-bot: I haz the power, 2015-04-09 04:28:45]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-04-09 04:29:43]

Patchset 2 (id:??) landed as
https://crrev.com/c2352bce792e735fc6be6f2d62c03652a3111e16
Cr-Commit-Position: refs/heads/master@{#324371}