Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/BUILD.gn

Issue 1071633003: GN Windows component build fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/BUILD.gn ('k') | content/app/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/BUILD.gn
diff --git a/content/BUILD.gn b/content/BUILD.gn
index 802ab2bba4a4aec3561a593066764d69b5193d41..2a7878c74fc771736260d91729098a4a3e215eb7 100644
--- a/content/BUILD.gn
+++ b/content/BUILD.gn
@@ -81,8 +81,11 @@ source_set("export") {
]
}
-if (is_win) {
- source_set("content_startup_helper_win") {
+# In the GYP build, this file is listed in several targets. In GN just have
+# those targets depend on this one. This can be depended on for any
+# platform for simplicity, and is a no-op on non-Windows.
+source_set("startup_helper_win") {
+ if (is_win) {
sources = [
"app/startup_helper_win.cc",
"public/app/startup_helper_win.h",
« no previous file with comments | « chrome/BUILD.gn ('k') | content/app/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698