Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 1071603005: Revert of Get gn_all/gyp_remaining working for Windows. (Closed)

Created:
5 years, 8 months ago by Dirk Pranke
Modified:
5 years, 8 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Get gn_all/gyp_remaining working for Windows. (patchset #2 id:20001 of https://codereview.chromium.org/1064333002/) Reason for revert: Seems to have broken the Win x64 debug builder: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20Builder%20(dbg)/builds/7600 Original issue's description: > Get gn_all/gyp_remaining working for Windows. > > This change doesn't actually cause anything new to be built, but it makes 'gn_all' and 'gyp_remaining' exist as targets on a windows build, and explicitly lists all of the targets built on win that weren't listed before. > > A number of these targets should actually build in a GN build, but I will take care of that in a follow-up CL. > > R=brettw@chromium.org > BUG=354261 > CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg > > Committed: https://crrev.com/eaef8f504d6e2a55626e2fb8b6c233f1d756d65c > Cr-Commit-Position: refs/heads/master@{#324285} TBR=brettw@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=354261 Committed: https://crrev.com/2fbb13254941a8a0c33695cbfde0389c53828e3b Cr-Commit-Position: refs/heads/master@{#324291}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -172 lines) Patch
M build/all.gyp View 1 chunk +1 line, -1 line 0 comments Download
M build/gn_migration.gypi View 11 chunks +62 lines, -171 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Created Revert of Get gn_all/gyp_remaining working for Windows.
5 years, 8 months ago (2015-04-08 22:07:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071603005/1
5 years, 8 months ago (2015-04-08 22:09:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 22:12:09 UTC) #3
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 22:13:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fbb13254941a8a0c33695cbfde0389c53828e3b
Cr-Commit-Position: refs/heads/master@{#324291}

Powered by Google App Engine
This is Rietveld 408576698