Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1071603002: Add helper for creating a SkSurface from a client created texture. (Closed)

Created:
5 years, 8 months ago by bsalomon
Modified:
5 years, 8 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Add helper for creating a SkSurface from a client created texture. Committed: https://skia.googlesource.com/skia/+/e4579adfdfb4b9f195d162835a69d9c2a974a6ac

Patch Set 1 #

Patch Set 2 : whitespace #

Patch Set 3 : whitespace #

Total comments: 2

Patch Set 4 : Fix comment style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -0 lines) Patch
M include/core/SkSurface.h View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M src/image/SkSurface.cpp View 1 chunk +4 lines, -0 lines 0 comments Download
M src/image/SkSurface_Gpu.cpp View 1 2 1 chunk +20 lines, -0 lines 0 comments Download
M tests/SurfaceTest.cpp View 2 chunks +40 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bsalomon
5 years, 8 months ago (2015-04-08 14:32:25 UTC) #2
reed1
lgtm https://codereview.chromium.org/1071603002/diff/40001/include/core/SkSurface.h File include/core/SkSurface.h (right): https://codereview.chromium.org/1071603002/diff/40001/include/core/SkSurface.h#newcode97 include/core/SkSurface.h:97: /** Used to wrap a pre-existing backend 3D ...
5 years, 8 months ago (2015-04-08 15:09:41 UTC) #3
bsalomon
https://codereview.chromium.org/1071603002/diff/40001/include/core/SkSurface.h File include/core/SkSurface.h (right): https://codereview.chromium.org/1071603002/diff/40001/include/core/SkSurface.h#newcode97 include/core/SkSurface.h:97: /** Used to wrap a pre-existing backend 3D API ...
5 years, 8 months ago (2015-04-08 15:14:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071603002/60001
5 years, 8 months ago (2015-04-08 15:14:28 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 15:38:45 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/e4579adfdfb4b9f195d162835a69d9c2a974a6ac

Powered by Google App Engine
This is Rietveld 408576698