Issue 1071583003: SkPDF: Remove Array's unused set(i) and get(i) (leaving only append())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1071583003: SkPDF: Remove Array's unused set(i) and get(i) (leaving only append()) (Closed)

Created:
5 years, 8 months ago by hal.canary

Modified:
5 years, 8 months ago

Reviewers:
tomhudson

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

SkPDF: Remove Array's unused set(i) and get(i) (leaving only append()) BUG=skia:3585 Committed: https://skia.googlesource.com/skia/+/2ad228e8ff3ad7050c58d563879b9831c688e2f1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -24 lines)			Patch
M	src/pdf/SkPDFTypes.h	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	src/pdf/SkPDFTypes.cpp	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	tests/PDFPrimitivesTest.cpp	View	2 chunks	+1 line, -4 lines	0 comments	Download

Total messages: 6 (2 generated)

tomhudson

Not needed because all we do during PDF *generation* is add values to these arrays, ...

5 years, 8 months ago (2015-04-08 15:21:28 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071583003/1

5 years, 8 months ago (2015-04-08 15:21:47 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-08 15:40:41 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2ad228e8ff3ad7050c58d563879b9831c688e2f1