Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: content/browser/indexed_db/indexed_db_browsertest.cc

Issue 1071553002: Optimizes the operation of DeleteDatabase when no backing store exists. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Incorporated review comments for browser tests. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_browsertest.cc
diff --git a/content/browser/indexed_db/indexed_db_browsertest.cc b/content/browser/indexed_db/indexed_db_browsertest.cc
index 21f6ad671169d1a724f4d752361451104f6c2528..9ad5b4dad2af2bed36f863a435a8ad6ef282f61e 100644
--- a/content/browser/indexed_db/indexed_db_browsertest.cc
+++ b/content/browser/indexed_db/indexed_db_browsertest.cc
@@ -492,22 +492,14 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DiskFullOnCommit) {
// => IndexedDBBackingStore::SetUpMetadata
// #2: IndexedDBBackingStore::OpenBackingStore
// => IndexedDBBackingStore::CleanUpBlobJournal (no-op)
- // * Then deletes the database:
- // #3: IndexedDBFactoryImpl::DeleteDatabase
- // => IndexedDBDatabase::Create
- // => IndexedDBBackingStore::CreateIDBDatabaseMetaData
- // #4: IndexedDBFactoryImpl::DeleteDatabase
- // => IndexedDBDatabase::DeleteDatabase
- // => IndexedDBBackingStore::DeleteDatabase
- // => IndexedDBBackingStore::CleanUpBlobJournal (no-op)
// * The test calls open(), to create a new database:
- // #5: IndexedDBFactoryImpl::Open
+ // #3: IndexedDBFactoryImpl::Open
// => IndexedDBDatabase::Create
// => IndexedDBBackingStore::CreateIDBDatabaseMetaData
- // #6: IndexedDBTransaction::Commit - initial "versionchange" transaction
+ // #4: IndexedDBTransaction::Commit - initial "versionchange" transaction
// * Once the connection is opened, the test runs:
- // #7: IndexedDBTransaction::Commit - the test's "readwrite" transaction)
- const int instance_num = 7;
+ // #5: IndexedDBTransaction::Commit - the test's "readwrite" transaction)
+ const int instance_num = 5;
const int call_num = 1;
FailOperation(FAIL_CLASS_LEVELDB_TRANSACTION, FAIL_METHOD_COMMIT_DISK_FULL,
instance_num, call_num);
« no previous file with comments | « no previous file | content/browser/indexed_db/indexed_db_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698