Optimizes the operation of DeleteDatabase when no backing store exists.

content/browser/indexed_db/indexed_db_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/file.h"
 #include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
@@ skipping 474 matching lines @@
   EXPECT_EQ(0, RequestDiskUsage());
 }
 
 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, DiskFullOnCommit) {
   // Ignore several preceding transactions:
   // * The test calls deleteDatabase() which opens the backing store:
   //   #1: IndexedDBBackingStore::OpenBackingStore
   //       => IndexedDBBackingStore::SetUpMetadata
   //   #2: IndexedDBBackingStore::OpenBackingStore
   //       => IndexedDBBackingStore::CleanUpBlobJournal (no-op)
   // * Then deletes the database:

[jsbell, 2015/04/22 21:30:07]

This part (lines 495 through 502) no longer happens. So delete this part of the
comment...

   //   #3: IndexedDBFactoryImpl::DeleteDatabase
   //       => IndexedDBDatabase::Create
   //       => IndexedDBBackingStore::CreateIDBDatabaseMetaData
   //   #4: IndexedDBFactoryImpl::DeleteDatabase
   //       => IndexedDBDatabase::DeleteDatabase
   //       => IndexedDBBackingStore::DeleteDatabase
   //       => IndexedDBBackingStore::CleanUpBlobJournal (no-op)
   // * The test calls open(), to create a new database:
   //   #5: IndexedDBFactoryImpl::Open

[jsbell, 2015/04/22 21:30:07]

And renumber this to #3

   //       => IndexedDBDatabase::Create
   //       => IndexedDBBackingStore::CreateIDBDatabaseMetaData
   //   #6: IndexedDBTransaction::Commit - initial "versionchange" transaction

[jsbell, 2015/04/22 21:30:07]

And renumber this to #4

   // * Once the connection is opened, the test runs:

[jsbell, 2015/04/22 21:30:07]

And this becomes #5, matching the instance_num change (yay!)

   //   #7: IndexedDBTransaction::Commit - the test's "readwrite" transaction)
-  const int instance_num = 7;
+  const int instance_num = 5;
   const int call_num = 1;
   FailOperation(FAIL_CLASS_LEVELDB_TRANSACTION, FAIL_METHOD_COMMIT_DISK_FULL,
                 instance_num, call_num);
   SimpleTest(GetTestUrl("indexeddb", "disk_full_on_commit.html"));
 }
 
 namespace {
 
 static void CompactIndexedDBBackingStore(
     scoped_refptr<IndexedDBContextImpl> context,
@@ skipping 318 matching lines @@
     command_line->AppendSwitch(switches::kSingleProcess);
   }
 };
 
 IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTestSingleProcess,
                        RenderThreadShutdownTest) {
   SimpleTest(GetTestUrl("indexeddb", "shutdown_with_requests.html"));
 }
 
 }  // namespace content