Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1071513003: win: Remove __alignof workaround, no longer needed. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
Reviewers:
DaleCurtis, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Remove __alignof workaround, no longer needed. No intended behavior change. BUG=none Committed: https://crrev.com/3ebecc3da14841cca6cd7dd3a8138cf72a565a24 Cr-Commit-Position: refs/heads/master@{#324272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M base/compiler_specific.h View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Nico
https://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types is marked as closed at least.
5 years, 8 months ago (2015-04-08 17:41:31 UTC) #2
Nico
https://connect.microsoft.com/VisualStudio/feedback/details/682695/c-alignof-fails-to-properly-evalute-alignment-of-dependent-types is marked as closed at least.
5 years, 8 months ago (2015-04-08 17:41:32 UTC) #4
scottmg
lgtm
5 years, 8 months ago (2015-04-08 17:54:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071513003/1
5 years, 8 months ago (2015-04-08 17:58:46 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-08 19:34:41 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3ebecc3da14841cca6cd7dd3a8138cf72a565a24 Cr-Commit-Position: refs/heads/master@{#324272}
5 years, 8 months ago (2015-04-08 19:35:28 UTC) #9
DaleCurtis
5 years, 8 months ago (2015-04-08 20:01:49 UTC) #10
Message was sent while issue was closed. 
\o/ lgtm

Powered by Google App Engine
This is Rietveld 408576698