Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(929)

Issue 1071473003: Fix maybe_string_add for adds that have no type feedback where --always-opt is on. (Closed)

Created:
5 years, 8 months ago by titzer
Modified:
5 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix maybe_string_add for adds that have no type feedback where --always-opt is on. R=mstarzinger@chromium.org BUG= Committed: https://crrev.com/a511c78999f508da1c5e447783c238916b2ca0a2 Cr-Commit-Position: refs/heads/master@{#27667}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Merge status file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -16 lines) Patch
M src/hydrogen.cc View 1 2 2 chunks +7 lines, -6 lines 0 comments Download
A test/mjsunit/compiler/generic-add.js View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M test/test262-es6/test262-es6.status View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M test/test262/test262.status View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
titzer
5 years, 8 months ago (2015-04-08 11:53:26 UTC) #1
Michael Starzinger
LGTM. Thanks!
5 years, 8 months ago (2015-04-08 11:57:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071473003/20001
5 years, 8 months ago (2015-04-08 11:58:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071473003/40001
5 years, 8 months ago (2015-04-08 12:41:36 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel/builds/4538)
5 years, 8 months ago (2015-04-08 12:43:00 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071473003/60001
5 years, 8 months ago (2015-04-08 12:50:35 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 8 months ago (2015-04-08 13:14:30 UTC) #14
commit-bot: I haz the power
5 years, 8 months ago (2015-04-08 13:14:43 UTC) #15
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/a511c78999f508da1c5e447783c238916b2ca0a2
Cr-Commit-Position: refs/heads/master@{#27667}

Powered by Google App Engine
This is Rietveld 408576698