Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Unified Diff: runtime/bin/eventhandler_linux.cc

Issue 107143005: Don't make timerfd non-blocking and add errno to error-mesage. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/eventhandler_linux.cc
diff --git a/runtime/bin/eventhandler_linux.cc b/runtime/bin/eventhandler_linux.cc
index 335238c4952c71e94b800bd4e92e9eb450517ee2..0db1f533efc6dfcfc5a970f08b01431f0c573438 100644
--- a/runtime/bin/eventhandler_linux.cc
+++ b/runtime/bin/eventhandler_linux.cc
@@ -134,8 +134,7 @@ EventHandlerImplementation::EventHandlerImplementation()
if (status == -1) {
FATAL("Failed adding interrupt fd to epoll instance");
}
- timer_fd_ = TEMP_FAILURE_RETRY(timerfd_create(CLOCK_REALTIME,
- TFD_NONBLOCK | TFD_CLOEXEC));
+ timer_fd_ = TEMP_FAILURE_RETRY(timerfd_create(CLOCK_REALTIME, TFD_CLOEXEC));
if (epoll_fd_ == -1) {
FATAL("Failed creating timerfd file descriptor");
}
@@ -147,7 +146,8 @@ EventHandlerImplementation::EventHandlerImplementation()
timer_fd_,
&event));
if (status == -1) {
- FATAL("Failed adding timerfd fd to epoll instance");
+ FATAL2(
+ "Failed adding timerfd fd(%i) to epoll instance: %i", timer_fd_, errno);
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698