Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 1071413004: Use nullptr in BrowserURLHandlerImpl constructor. (Closed)

Created:
5 years, 8 months ago by Charlie Reis
Modified:
5 years, 8 months ago
Reviewers:
adamk
CC:
chromium-reviews, darin-cc_chromium.org, jam, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use nullptr in BrowserURLHandlerImpl constructor. BUG=477065 TEST=Likely no behavior change; maybe eliminate a crash. Committed: https://crrev.com/5c0d01db03d8ea58391de07754c75625ae8fd469 Cr-Commit-Position: refs/heads/master@{#326901}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M content/browser/browser_url_handler_impl.cc View 2 chunks +2 lines, -2 lines 1 comment Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Might as well switch to nullptr, though I'd be surprised if that had any effect ...
5 years, 8 months ago (2015-04-24 21:22:52 UTC) #2
adamk
lgtm
5 years, 8 months ago (2015-04-24 21:35:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071413004/1
5 years, 8 months ago (2015-04-24 22:04:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-24 22:16:36 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-24 22:18:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c0d01db03d8ea58391de07754c75625ae8fd469
Cr-Commit-Position: refs/heads/master@{#326901}

Powered by Google App Engine
This is Rietveld 408576698