MediaDrmBridge: guards MediaDrm.removeKeys call in case of failure.

MediaDrmBridge: guards MediaDrm.removeKeys call in case of failure.

R=xhwang@chromium.org
BUG=475632
Committed: https://crrev.com/2d51d5f255ee038c0770fc101660728a3e44339a
Cr-Commit-Position: refs/heads/master@{#324692}

[gunsch, 2015-04-10 00:46:35]

Not sure if this is the most appropriate action here. I'm trying to follow up on
the plugin side as well (see b/20136945).

One note: the plugin is currently throwing a MediaDrm.MediaDrmStateException,
which wasn't added until API Level 21. Catching Exception doesn't feel great,
but neither does crashing at the end of every video.

[xhwang, 2015-04-10 04:44:15]

On 2015/04/10 00:46:35, gunsch wrote:
> Not sure if this is the most appropriate action here. I'm trying to follow up
on
> the plugin side as well (see b/20136945).
> 
> One note: the plugin is currently throwing a MediaDrm.MediaDrmStateException,
> which wasn't added until API Level 21. Catching Exception doesn't feel great,
> but neither does crashing at the end of every video.

Thanks for tracking this up in chromium and android! Can you add comments with
the bug number in this CL so that readers don't get lost why we are catching
exceptions here? Otherwise, LGTM!

[xhwang, 2015-04-10 04:44:22]

https://codereview.chromium.org/1071413002/diff/1/media/base/android/java/src...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/1071413002/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:384:
Log.e(TAG, "removeKeys failed: ", e);
add a comment with bug number

https://codereview.chromium.org/1071413002/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:578:
Log.e(TAG, "removeKeys failed: ", e);
add a comment with bug number

[gunsch, 2015-04-10 20:47:17]

https://codereview.chromium.org/1071413002/diff/1/media/base/android/java/src...
File media/base/android/java/src/org/chromium/media/MediaDrmBridge.java (right):

https://codereview.chromium.org/1071413002/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:384:
Log.e(TAG, "removeKeys failed: ", e);
On 2015/04/10 04:44:22, xhwang wrote:
> add a comment with bug number

Done.

https://codereview.chromium.org/1071413002/diff/1/media/base/android/java/src...
media/base/android/java/src/org/chromium/media/MediaDrmBridge.java:578:
Log.e(TAG, "removeKeys failed: ", e);
On 2015/04/10 04:44:22, xhwang wrote:
> add a comment with bug number

Done.

[gunsch, 2015-04-10 20:47:44]

The CQ bit was checked by gunsch@chromium.org

[gunsch, 2015-04-10 20:47:44]

The patchset sent to the CQ was uploaded after l-g-t-m from xhwang@chromium.org
Link to the patchset: https://codereview.chromium.org/1071413002/#ps20001
(title: "adds comments about the try/catch")

[commit-bot: I haz the power, 2015-04-10 20:48:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1071413002/20001

[commit-bot: I haz the power, 2015-04-10 21:59:49]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-04-10 22:00:50]

Patchset 2 (id:??) landed as
https://crrev.com/2d51d5f255ee038c0770fc101660728a3e44339a
Cr-Commit-Position: refs/heads/master@{#324692}