chrome/browser/extensions/display_info_provider_chromeos.cc - Issue 1071353003: Prevent DisplayPreferences from saving incorrect rotations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/display_info_provider_chromeos.cc

Issue 1071353003: Prevent DisplayPreferences from saving incorrect rotations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/display/display_preferences_unittest.cc ('k') | chrome/browser/extensions/display_info_provider_chromeos_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/display_info_provider_chromeos.cc

diff --git a/chrome/browser/extensions/display_info_provider_chromeos.cc b/chrome/browser/extensions/display_info_provider_chromeos.cc

index fda4b63bb29145367708f24de0813c3b924144f0..673a15a7062cf448ec9cb397e6fa9ec22bebe57d 100644

--- a/chrome/browser/extensions/display_info_provider_chromeos.cc

+++ b/chrome/browser/extensions/display_info_provider_chromeos.cc

@@ -334,7 +334,8 @@ bool DisplayInfoProviderChromeOS::SetInfo(const std::string& display_id_str,

// Process 'rotation' parameter.

if (info.rotation) {

display_manager->SetDisplayRotation(display_id,

- DegreesToRotation(*info.rotation));

+ DegreesToRotation(*info.rotation),

+ gfx::Display::ROTATION_SOURCE_ACTIVE);

}

// Process new display origin parameters.