Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1071333004: [turbofan] JSUnaryNot and JSToBoolean have exactly 2 inputs, no need to trim. (Closed)

Created:
5 years, 8 months ago by Benedikt Meurer
Modified:
5 years, 8 months ago
Reviewers:
dcarney
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] JSUnaryNot and JSToBoolean have exactly 2 inputs, no need to trim. R=dcarney@chromium.org Committed: https://crrev.com/d8679a2350ace9cc29667b3e0ad9ab87f02b6793 Cr-Commit-Position: refs/heads/master@{#27741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/compiler/js-typed-lowering.cc View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 8 months ago (2015-04-10 10:43:49 UTC) #1
Benedikt Meurer
Hey Dan, This is hopefully obvious. Please take a look. :-) Thanks, Benedikt
5 years, 8 months ago (2015-04-10 10:44:26 UTC) #2
dcarney
lgtm
5 years, 8 months ago (2015-04-10 10:50:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071333004/1
5 years, 8 months ago (2015-04-10 10:51:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-10 11:08:55 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-04-10 11:09:07 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d8679a2350ace9cc29667b3e0ad9ab87f02b6793
Cr-Commit-Position: refs/heads/master@{#27741}

Powered by Google App Engine
This is Rietveld 408576698