Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1071303003: Remove Document mode promo page from First Run. (Closed)

Created:
5 years, 8 months ago by aurimas (slooooooooow)
Modified:
5 years, 8 months ago
Reviewers:
aruslan
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Document mode promo page from First Run. "Merge apps and tabs" feature promotion is moving to the new tab page so it is no longer needed in first run. BUG=467437 Committed: https://crrev.com/eafe991245806b6b07046c9a2d35c3283ec7d8fd Cr-Commit-Position: refs/heads/master@{#325343}

Patch Set 1 #

Total comments: 8

Patch Set 2 : aruslan's nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -459 lines) Patch
D chrome/android/java/res/drawable-hdpi/fre_new_recents_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-hdpi/fre_new_recents_menu_loupe.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/fre_new_recents_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-mdpi/fre_new_recents_menu_loupe.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/fre_new_recents_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xhdpi/fre_new_recents_menu_loupe.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/fre_new_recents_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxhdpi/fre_new_recents_menu_loupe.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/fre_new_recents_menu.png View Binary file 0 comments Download
D chrome/android/java/res/drawable-xxxhdpi/fre_new_recents_menu_loupe.png View Binary file 0 comments Download
D chrome/android/java/res/layout/fre_page.xml View 1 chunk +0 lines, -114 lines 0 comments Download
M chrome/android/java/res/values/dimens.xml View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java View 1 6 chunks +1 line, -29 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunFlowSequencer.java View 1 4 chunks +3 lines, -19 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunIntroPage.java View 1 chunk +0 lines, -148 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunIntroRecentsPage.java View 1 chunk +0 lines, -128 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPageDelegate.java View 1 2 chunks +0 lines, -11 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
aurimas (slooooooooow)
PTAL
5 years, 8 months ago (2015-04-14 22:02:36 UTC) #2
aruslan
lgtm, thanks! -- and please remove the rest of SKIP_ALL_INTROS and skipIntroPages(). https://chromiumcodereview.appspot.com/1071303003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java ...
5 years, 8 months ago (2015-04-14 22:13:51 UTC) #3
aurimas (slooooooooow)
https://chromiumcodereview.appspot.com/1071303003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java File chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java (right): https://chromiumcodereview.appspot.com/1071303003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java#newcode50 chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunActivity.java:50: public static final String SHOW_INTRO_BITMAP = "ShowIntroBitmap"; On 2015/04/14 ...
5 years, 8 months ago (2015-04-15 00:09:36 UTC) #4
aurimas (slooooooooow)
Addressed all the comments.
5 years, 8 months ago (2015-04-15 00:10:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071303003/20001
5 years, 8 months ago (2015-04-15 23:04:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-04-15 23:34:26 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-04-15 23:35:23 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/eafe991245806b6b07046c9a2d35c3283ec7d8fd
Cr-Commit-Position: refs/heads/master@{#325343}

Powered by Google App Engine
This is Rietveld 408576698