Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 1071283004: Encoding API: ignore leading/trailing whitespace in labels (Closed)

Created:
5 years, 8 months ago by jsbell
Modified:
5 years, 7 months ago
Reviewers:
jungshik at Google
CC:
blink-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Encoding API: ignore leading/trailing whitespace in labels Per spec, matching of labels should be done after removing leading and trailing ASCII whitespace[1]. A specific definition of whitespace is given in the spec[2]. Test was adapted from web-platform-tests[3] but extended to cover failure more cases and the encoder side; this will be upstreamed/deduped eventually. [1] https://encoding.spec.whatwg.org/#names-and-labels [2] https://encoding.spec.whatwg.org/#ascii-whitespace [3] https://github.com/w3c/web-platform-tests/blob/master/encoding/textdecoder-labels.html R=jshin@chromium.org BUG=479785 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -2 lines) Patch
A LayoutTests/fast/encoding/api/textdecoder-labels.html View 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/api/textencoder-labels.html View 1 chunk +51 lines, -0 lines 0 comments Download
A Source/modules/encoding/Encoding.h View 1 chunk +22 lines, -0 lines 0 comments Download
A Source/modules/encoding/Encoding.cpp View 1 chunk +21 lines, -0 lines 0 comments Download
M Source/modules/encoding/TextDecoder.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/encoding/TextEncoder.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/modules.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
jsbell
jshin@ - please take a look?
5 years, 8 months ago (2015-04-24 17:44:41 UTC) #1
jungshik at Google
On 2015/04/24 17:44:41, jsbell wrote: > jshin@ - please take a look? Ooops. I thought ...
5 years, 7 months ago (2015-04-29 20:23:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071283004/1
5 years, 7 months ago (2015-04-29 20:25:34 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=194676
5 years, 7 months ago (2015-04-29 22:20:17 UTC) #5
jsbell
On 2015/04/29 22:20:17, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
5 years, 7 months ago (2015-04-29 22:31:33 UTC) #6
jsbell
5 years, 7 months ago (2015-04-29 22:34:09 UTC) #7
Message was sent while issue was closed.
> Ugh, I forgot to rebase the imported/web-platform-tests version
> 
> That will probably start failing. Will rebase that shortly.

Oh, false alarm - that test is skipped since the failures had unescaped control
characters that confused rietveld.

Powered by Google App Engine
This is Rietveld 408576698