Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1071273004: Revert of Update V8 to version 4.4.7. (Closed)

Created:
5 years, 8 months ago by Nico
Modified:
5 years, 8 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 4.4.7. (patchset #1 id:1 of https://codereview.chromium.org/1076733002/) Reason for revert: Broke clang/win waterfall. https://codereview.chromium.org/1073903002/ fixes this, but I'd prefer if the bot wasn't red until that makes it into chromium. Original issue's description: > Update V8 to version 4.4.7. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/ca9f7433..1cb04a8e > > Please follow these instructions for assigning/CC'ing issues: > https://code.google.com/p/v8-wiki/wiki/TriagingIssues > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > BUG= > > Committed: https://crrev.com/d5d071430ce150bc1aec08291c51c70673878973 > Cr-Commit-Position: refs/heads/master@{#324410} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
Nico
Created Revert of Update V8 to version 4.4.7.
5 years, 8 months ago (2015-04-09 19:54:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1071273004/1
5 years, 8 months ago (2015-04-09 19:55:44 UTC) #2
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-04-09 19:56:52 UTC) #4
Nico
Gah!
5 years, 8 months ago (2015-04-09 20:57:20 UTC) #5
Michael Achenbach
Where is this bot and why is it not covered by the CQ? I don't ...
5 years, 8 months ago (2015-04-09 21:00:35 UTC) #6
Michael Achenbach
I'll cherry-pick the fix onto the current roll.
5 years, 8 months ago (2015-04-09 21:08:07 UTC) #7
Nico
5 years, 8 months ago (2015-04-09 21:08:54 UTC) #8
(we talked on chat, all sorted out)

On Thu, Apr 9, 2015 at 2:00 PM, <machenbach@chromium.org> wrote:

> Where is this bot and why is it not covered by the CQ?
>
> I don't see any red tree closer. Furthermore, since this roll there landed
> two
> more...
>
> Generally I'd prefer to cherry-pick the v8-side fix or maybe a revert of
> the
> culprit onto a roll, because reverting several v8 rolls costs us the canary
> coverage for a day.
>
> https://codereview.chromium.org/1071273004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698