Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1103)

Unified Diff: content/browser/notifications/notification_event_dispatcher_impl.cc

Issue 1071203002: Consistently handle persistent notification ids as int64_t (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@n-db-Integrate
Patch Set: rebase Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/notifications/notification_event_dispatcher_impl.cc
diff --git a/content/browser/notifications/notification_event_dispatcher_impl.cc b/content/browser/notifications/notification_event_dispatcher_impl.cc
index 34fe581f79935c51b464b385ada1f1c87cdb47da..b1119616b36c884d044303c4743a2a57126aabf4 100644
--- a/content/browser/notifications/notification_event_dispatcher_impl.cc
+++ b/content/browser/notifications/notification_event_dispatcher_impl.cc
@@ -5,7 +5,6 @@
#include "content/browser/notifications/notification_event_dispatcher_impl.h"
#include "base/callback.h"
-#include "base/strings/string_number_conversions.h"
#include "content/browser/notifications/platform_notification_context_impl.h"
#include "content/browser/service_worker/service_worker_context_wrapper.h"
#include "content/browser/service_worker/service_worker_registration.h"
@@ -77,15 +76,10 @@ void DispatchNotificationClickEventOnRegistration(
dispatch_complete_callback,
service_worker_registration);
- // TODO(peter): Pass the persistent notification id as an int64_t rather
- // than as a string. This depends on the Blink API being updated.
- std::string persistent_notification_id_string =
- base::Int64ToString(notification_database_data.notification_id);
-
service_worker_registration->active_version()->
DispatchNotificationClickEvent(
dispatch_event_callback,
- persistent_notification_id_string,
+ notification_database_data.notification_id,
notification_database_data.notification_data);
return;
}
« no previous file with comments | « no previous file | content/browser/service_worker/service_worker_version.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698