ui/views/controls/menu/menu_controller_unittest.cc - Issue 1071193002: Change device IDs from unsigned to signed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/menu/menu_controller_unittest.cc

Issue 1071193002: Change device IDs from unsigned to signed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: check for negative IDs Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/menu/menu_controller_unittest.cc

diff --git a/ui/views/controls/menu/menu_controller_unittest.cc b/ui/views/controls/menu/menu_controller_unittest.cc

index 99e889a76c9dc550477108b41c0e3384e3e37beb..73461e07ede6f408764c77e1af494b8637197817 100644

--- a/ui/views/controls/menu/menu_controller_unittest.cc

+++ b/ui/views/controls/menu/menu_controller_unittest.cc

@@ -296,7 +296,7 @@ TEST_F(MenuControllerTest, TouchIdsReleasedCorrectly) {

owner->GetNativeWindow()->GetRootWindow()->AddPreTargetHandler(

&test_event_handler);

- std::vector<unsigned int> devices;

+ std::vector<int> devices;

devices.push_back(1);

ui::SetUpTouchDevicesForTest(devices);